Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Fix up Endgame34 #15366

Merged
merged 1 commit into from
Nov 30, 2021
Merged

[Keyboard] Fix up Endgame34 #15366

merged 1 commit into from
Nov 30, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Nov 30, 2021

Description

fixes compilation issue with OLED function types.

Also, moves oled code to keyboard level, and updates it a bit.

Types of Changes

  • Bugfix
  • Enhancement/optimization
  • Keyboard (addition or update)

Issues Fixed or Closed by This PR

  • Tzarc CI

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna added the bug label Nov 30, 2021
@drashna drashna requested a review from a team November 30, 2021 18:45
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 30, 2021
@tzarc tzarc merged commit d184a85 into qmk:master Nov 30, 2021
@drashna drashna deleted the keyboard/endgame34_fix branch November 30, 2021 19:18
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Dec 2, 2021
Merge remote-tracking branch 'qmk/develop' into develop
09b3951 
* qmk/develop: (76 commits)
  Update ReadMe for the Roopad (qmk#15380)
  Tidy up existing i2c_master implementations (qmk#15376)
  Remove pointless `CUSTOM_MATRIX = no` (qmk#15383)
  Remove manual enable of LTO within keyboards (qmk#15377)
  [Keyboard] Han60 QMK / VIA Support (qmk#15332)
  Convert ai03/orbit to SPLIT_KEYBOARD (qmk#15340)
  Convert not_so_minidox to SPLIT_KEYBOARD (qmk#15306)
  Tidy up `SLEEP_LED_ENABLE` rules (qmk#15362)
  [Keyboard] Add support for Mode SixtyFive M65HA and M65HI (qmk#14685)
  Implement MAGIC_TOGGLE_CONTROL_CAPSLOCK (qmk#15368)
  Rename Layout Macros for TKLs with F13 keys (qmk#15361)
  [Docs] Reorder functions in Understanding QMK (qmk#15357)
  [Keyboard] Fix up Endgame34 (qmk#15366)
  [Keyboard] Fix compilation issues for Ploopy Trackball classic (qmk#15364)
  [Keyboard] Add missng define for 4x6 Tractyl Manuform (qmk#15363)
  [Core] Added chconf.h for WB32 (qmk#15359)
  [Keyboard] kangaroo improvements (qmk#15350)
  [Keyboard] Convert ergoinu to SPLIT_KEYBOARD (qmk#15305)
  [Keymap] Keebio Sinc layout with macOS support (qmk#15324)
  Fixup paths for `ramonimbao/wete/v2`. (qmk#15360)
  ...
rudism pushed a commit to rudism/qmk_firmware that referenced this pull request Jan 16, 2022
@drashna @rudism
[Keyboard] Fix up Endgame34 (qmk#15366)
fc541dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @tzarc @fauxpark