Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] add ProjectCain Relic #15577

Merged
merged 13 commits into from
Jul 16, 2022
Merged

[Keyboard] add ProjectCain Relic #15577

merged 13 commits into from
Jul 16, 2022

Conversation

projectcain
Copy link

Hello - I'm looking to add my most recent keyboard to my folder available on qmk master.

Description

Dropped a completed firmware folder in keyboards/projectcain to add support for relic

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Dec 28, 2021
View reviewed changes
keyboards/projectcain/relic/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/projectcain/relic/relic.c Outdated Show resolved Hide resolved
keyboards/projectcain/relic/relic.c Outdated Show resolved Hide resolved
keyboards/projectcain/relic/rules.mk Outdated Show resolved Hide resolved
keyboards/projectcain/relic/rules.mk Outdated Show resolved Hide resolved
keyboards/projectcain/relic/rules.mk Outdated Show resolved Hide resolved
projectcain and others added 7 commits December 28, 2021 22:27
@projectcain @drashna
Update keyboards/projectcain/relic/relic.c
c30b55f 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@projectcain @drashna
Update keyboards/projectcain/relic/relic.c
c3256d4 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@projectcain @drashna
Update keyboards/projectcain/relic/rules.mk
e30fc25 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@projectcain @drashna
Update keyboards/projectcain/relic/rules.mk
a7e7371 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@projectcain @drashna
Update keyboards/projectcain/relic/rules.mk
85e2d8e 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@projectcain
Update config.h
5f17d8a
@projectcain
Update config.h
ae3d250
@projectcain projectcain requested a review from drashna December 30, 2021 01:07
@drashna drashna requested a review from a team January 7, 2022 00:20
fauxpark
fauxpark requested changes Jan 10, 2022
View reviewed changes
keyboards/projectcain/relic/rules.mk Outdated Show resolved Hide resolved
keyboards/projectcain/relic/readme.md Outdated Show resolved Hide resolved
projectcain and others added 2 commits January 10, 2022 18:31
@projectcain @fauxpark
Update keyboards/projectcain/relic/rules.mk
f9add66 
Co-authored-by: Ryan <fauxpark@gmail.com>
@projectcain @fauxpark
Update keyboards/projectcain/relic/readme.md
5b312c1 
Co-authored-by: Ryan <fauxpark@gmail.com>
@projectcain projectcain requested a review from fauxpark January 11, 2022 00:33
noroadsleft
noroadsleft requested changes Mar 10, 2022
View reviewed changes
keyboards/projectcain/relic/config.h Outdated Show resolved Hide resolved
keyboards/projectcain/relic/config.h
Comment on lines +60 to +86
// #define RGB_DI_PIN E2
// #ifdef RGB_DI_PIN
// #define RGBLED_NUM 16
// #define RGBLIGHT_HUE_STEP 8
// #define RGBLIGHT_SAT_STEP 8
// #define RGBLIGHT_VAL_STEP 8
// #define RGBLIGHT_LIMIT_VAL 255 /* The maximum brightness level */
// #define RGBLIGHT_SLEEP /* If defined, the RGB lighting will be switched off when the host goes to sleep */
// /*== all animations enable ==*/
// #define RGBLIGHT_ANIMATIONS
// /*== or choose animations ==*/
// #define RGBLIGHT_EFFECT_BREATHING
// #define RGBLIGHT_EFFECT_RAINBOW_MOOD
// #define RGBLIGHT_EFFECT_RAINBOW_SWIRL
// #define RGBLIGHT_EFFECT_SNAKE
// #define RGBLIGHT_EFFECT_KNIGHT
// #define RGBLIGHT_EFFECT_CHRISTMAS
// #define RGBLIGHT_EFFECT_STATIC_GRADIENT
// #define RGBLIGHT_EFFECT_RGB_TEST
// #define RGBLIGHT_EFFECT_ALTERNATING
// /*== customize breathing effect ==*/
// /*==== (DEFAULT) use fixed table instead of exp() and sin() ====*/
// #define RGBLIGHT_BREATHE_TABLE_SIZE 256 // 256(default) or 128 or 64
// /*==== use exp() and sin() ====*/
// #define RGBLIGHT_EFFECT_BREATHE_CENTER 1.85 // 1 to 2.7
// #define RGBLIGHT_EFFECT_BREATHE_MAX 255 // 0 to 255
// #endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PCB appears to have a breakout for attaching an RGB LED strip. You should uncomment RGB_DI_PIN and set it to the RGB Data pin, and I personally would wrap the rest in #if defined(RGBLIGHT_ENABLE) (Line 61).

fauxpark
fauxpark requested changes Mar 10, 2022
View reviewed changes
keyboards/projectcain/relic/config.h Outdated Show resolved Hide resolved
keyboards/projectcain/relic/info.json Outdated Show resolved Hide resolved
projectcain and others added 3 commits March 12, 2022 19:40
@projectcain @fauxpark
Update keyboards/projectcain/relic/info.json
0b155fb 
Co-authored-by: Ryan <fauxpark@gmail.com>
@projectcain @fauxpark
Update keyboards/projectcain/relic/config.h
e8e7161 
Co-authored-by: Ryan <fauxpark@gmail.com>
@projectcain @noroadsleft
Update keyboards/projectcain/relic/config.h
0a438ca 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@stale
Copy link

stale bot commented Jun 12, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@drashna drashna requested a review from a team June 12, 2022 18:46
@stale stale bot removed the awaiting changes label Jun 12, 2022
@noroadsleft noroadsleft merged commit f5333e9 into qmk:master Jul 16, 2022
@noroadsleft
Copy link
Member

Thanks!

WonderBeat pushed a commit to post-engineering/qmk_firmware that referenced this pull request Jul 16, 2022
Merge branch 'master' of github.com:qmk/qmk_firmware
b165cf2 
* 'master' of github.com:qmk/qmk_firmware: (179 commits)
  [Keymap] Crkbd/thunderbird2086 (qmk#16973)
  Suavity Ehan Refactor (qmk#17694)
  feat(keebwerk): added VIA support keymap for keebwerk nano slider (qmk#16761)
  FJLabs Solanis Refactor (qmk#17686)
  [Keyboard] add ProjectCain Relic (qmk#15577)
  [Keyboard] eHan Keyboard (qmk#15861)
  Move ins, home and pgup keys to the left (qmk#17690)
  [Keymap] emp keymap for keebio/iris (qmk#16858)
  Ignore kbfirmware exports (qmk#17687)
  [Keyboard] Added TutelPad keyboard (qmk#16975)
  [Keyboard] Add Chocofly v1 (qmk#17289)
  KB16-01: correct QMK Configurator key sequence (qmk#17670)
  Nayeon Community Layout support (qmk#17665)
  [Keyboard] Fix Tractyl Manuform 4x6 json (qmk#17681)
  [Keyboard] Readme file correction (qmk#17674)
  KPrepublic BM80v2 ISO Refactor (qmk#17660)
  [Keyboard] MechWild BB Steno (qmk#17163)
  [Keyboard] Modelm101 teensy2 (qmk#16805)
  Ducky One 2 SF touch-up (qmk#17672)
  Gentoo & Gentoo Hotswap: correct Configurator key sequence errors (qmk#17668)
  ...
smocky pushed a commit to smocky/qmk_firmware that referenced this pull request Jul 22, 2022
@projectcain @smocky
[Keyboard] add ProjectCain Relic (qmk#15577)
a16c8db 
* Adding relic keyboard

* Update keyboards/projectcain/relic/relic.c

* Update keyboards/projectcain/relic/relic.c

* Update keyboards/projectcain/relic/rules.mk

* Update keyboards/projectcain/relic/rules.mk

* Update keyboards/projectcain/relic/rules.mk

* Update config.h

* Update config.h

* Update keyboards/projectcain/relic/rules.mk

* Update keyboards/projectcain/relic/readme.md

* Update keyboards/projectcain/relic/info.json

* Update keyboards/projectcain/relic/config.h

* Update keyboards/projectcain/relic/config.h
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
@projectcain @schattenbrot
[Keyboard] add ProjectCain Relic (qmk#15577)
3f533cb 
* Adding relic keyboard

* Update keyboards/projectcain/relic/relic.c

* Update keyboards/projectcain/relic/relic.c

* Update keyboards/projectcain/relic/rules.mk

* Update keyboards/projectcain/relic/rules.mk

* Update keyboards/projectcain/relic/rules.mk

* Update config.h

* Update config.h

* Update keyboards/projectcain/relic/rules.mk

* Update keyboards/projectcain/relic/readme.md

* Update keyboards/projectcain/relic/info.json

* Update keyboards/projectcain/relic/config.h

* Update keyboards/projectcain/relic/config.h
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@projectcain @imhoffman
[Keyboard] add ProjectCain Relic (qmk#15577)
dfcbe77 
* Adding relic keyboard

* Update keyboards/projectcain/relic/relic.c

* Update keyboards/projectcain/relic/relic.c

* Update keyboards/projectcain/relic/rules.mk

* Update keyboards/projectcain/relic/rules.mk

* Update keyboards/projectcain/relic/rules.mk

* Update config.h

* Update config.h

* Update keyboards/projectcain/relic/rules.mk

* Update keyboards/projectcain/relic/readme.md

* Update keyboards/projectcain/relic/info.json

* Update keyboards/projectcain/relic/config.h

* Update keyboards/projectcain/relic/config.h
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@projectcain @nolanseaton
[Keyboard] add ProjectCain Relic (qmk#15577)
0bf848c 
* Adding relic keyboard

* Update keyboards/projectcain/relic/relic.c

* Update keyboards/projectcain/relic/relic.c

* Update keyboards/projectcain/relic/rules.mk

* Update keyboards/projectcain/relic/rules.mk

* Update keyboards/projectcain/relic/rules.mk

* Update config.h

* Update config.h

* Update keyboards/projectcain/relic/rules.mk

* Update keyboards/projectcain/relic/readme.md

* Update keyboards/projectcain/relic/info.json

* Update keyboards/projectcain/relic/config.h

* Update keyboards/projectcain/relic/config.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@projectcain @noroadsleft @drashna @fauxpark