Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new keymap for keebio/iris #16858

Merged
merged 6 commits into from
Jul 15, 2022
Merged

Added new keymap for keebio/iris #16858

merged 6 commits into from
Jul 15, 2022

Conversation

elliotpatros
Copy link

Description

My personal layout for the keebio/iris. Really simple, only two layers, have been using it for work for several years.

Added keymap.c and config.h to keyboards/keebio/iris/keymaps/emp

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [nearly] My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Apr 16, 2022
View reviewed changes
keyboards/keebio/iris/keymaps/emp/config.h Outdated Show resolved Hide resolved
@zvecr zvecr changed the title Added new layout for keebio/iris Added new keymap for keebio/iris Apr 16, 2022
@elliotpatros @zvecr
Update keyboards/keebio/iris/keymaps/emp/config.h
ee40f7c 
Co-authored-by: Joel Challis <git@zvecr.com>
drashna
drashna requested changes Apr 16, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the formatting bothers me

keyboards/keebio/iris/keymaps/emp/keymap.c Show resolved Hide resolved
keyboards/keebio/iris/keymaps/emp/keymap.c Outdated Show resolved Hide resolved
elliotpatros and others added 4 commits April 16, 2022 13:16
@elliotpatros @drashna
Update keyboards/keebio/iris/keymaps/emp/keymap.c
a47d5f1 
Replace #defines with enum

Co-authored-by: Drashna Jaelre <drashna@live.com>
@elliotpatros
Update keyboards/keebio/iris/keymaps/emp/keymap.c
88e1ea9 
Made requested changes about formatting and the license.
@elliotpatros
Update config.h
1c07bfa 
Cleaned up formatting
@elliotpatros
Update keyboards/keebio/iris/keymaps/emp/keymap.c
9830e69 
Small changes to improve readability:
* changed whitespace in license
* added more whitespace around if/else blocks
* fixed bracket style in places
@drashna drashna requested a review from a team April 18, 2022 09:26
@stale
Copy link

stale bot commented Jun 12, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@noroadsleft noroadsleft merged commit 0ececbc into qmk:master Jul 15, 2022
@noroadsleft
Copy link
Member

Thanks!

WonderBeat pushed a commit to post-engineering/qmk_firmware that referenced this pull request Jul 16, 2022
Merge branch 'master' of github.com:qmk/qmk_firmware
b165cf2 
* 'master' of github.com:qmk/qmk_firmware: (179 commits)
  [Keymap] Crkbd/thunderbird2086 (qmk#16973)
  Suavity Ehan Refactor (qmk#17694)
  feat(keebwerk): added VIA support keymap for keebwerk nano slider (qmk#16761)
  FJLabs Solanis Refactor (qmk#17686)
  [Keyboard] add ProjectCain Relic (qmk#15577)
  [Keyboard] eHan Keyboard (qmk#15861)
  Move ins, home and pgup keys to the left (qmk#17690)
  [Keymap] emp keymap for keebio/iris (qmk#16858)
  Ignore kbfirmware exports (qmk#17687)
  [Keyboard] Added TutelPad keyboard (qmk#16975)
  [Keyboard] Add Chocofly v1 (qmk#17289)
  KB16-01: correct QMK Configurator key sequence (qmk#17670)
  Nayeon Community Layout support (qmk#17665)
  [Keyboard] Fix Tractyl Manuform 4x6 json (qmk#17681)
  [Keyboard] Readme file correction (qmk#17674)
  KPrepublic BM80v2 ISO Refactor (qmk#17660)
  [Keyboard] MechWild BB Steno (qmk#17163)
  [Keyboard] Modelm101 teensy2 (qmk#16805)
  Ducky One 2 SF touch-up (qmk#17672)
  Gentoo & Gentoo Hotswap: correct Configurator key sequence errors (qmk#17668)
  ...
smocky pushed a commit to smocky/qmk_firmware that referenced this pull request Jul 22, 2022
@elliotpatros @smocky
[Keymap] emp keymap for keebio/iris (qmk#16858)
c1a31fc 
* added new layout for keebio/iris

* Update keyboards/keebio/iris/keymaps/emp/config.h

* Update keyboards/keebio/iris/keymaps/emp/keymap.c

Replace #defines with enum

* Update keyboards/keebio/iris/keymaps/emp/keymap.c

Made requested changes about formatting and the license.

* Update config.h

Cleaned up formatting

* Update keyboards/keebio/iris/keymaps/emp/keymap.c

Small changes to improve readability:
* changed whitespace in license
* added more whitespace around if/else blocks
* fixed bracket style in places
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
@elliotpatros @schattenbrot
[Keymap] emp keymap for keebio/iris (qmk#16858)
9239517 
* added new layout for keebio/iris

* Update keyboards/keebio/iris/keymaps/emp/config.h

* Update keyboards/keebio/iris/keymaps/emp/keymap.c

Replace #defines with enum

* Update keyboards/keebio/iris/keymaps/emp/keymap.c

Made requested changes about formatting and the license.

* Update config.h

Cleaned up formatting

* Update keyboards/keebio/iris/keymaps/emp/keymap.c

Small changes to improve readability:
* changed whitespace in license
* added more whitespace around if/else blocks
* fixed bracket style in places
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@elliotpatros @imhoffman
[Keymap] emp keymap for keebio/iris (qmk#16858)
a84bcf5 
* added new layout for keebio/iris

* Update keyboards/keebio/iris/keymaps/emp/config.h

* Update keyboards/keebio/iris/keymaps/emp/keymap.c

Replace #defines with enum

* Update keyboards/keebio/iris/keymaps/emp/keymap.c

Made requested changes about formatting and the license.

* Update config.h

Cleaned up formatting

* Update keyboards/keebio/iris/keymaps/emp/keymap.c

Small changes to improve readability:
* changed whitespace in license
* added more whitespace around if/else blocks
* fixed bracket style in places
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@elliotpatros @nolanseaton
[Keymap] emp keymap for keebio/iris (qmk#16858)
aebbfb6 
* added new layout for keebio/iris

* Update keyboards/keebio/iris/keymaps/emp/config.h

* Update keyboards/keebio/iris/keymaps/emp/keymap.c

Replace #defines with enum

* Update keyboards/keebio/iris/keymaps/emp/keymap.c

Made requested changes about formatting and the license.

* Update config.h

Cleaned up formatting

* Update keyboards/keebio/iris/keymaps/emp/keymap.c

Small changes to improve readability:
* changed whitespace in license
* added more whitespace around if/else blocks
* fixed bracket style in places
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
awaiting changes keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elliotpatros @noroadsleft @drashna @zvecr