Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tada68 into kbdfans's vendor folder #15703

Closed
wants to merge 1 commit into from

Conversation

peepeetee
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 2, 2022
@peepeetee
Copy link
Contributor Author

In #5025 by @mechmerlin:

Boards left out, are the dz60 and tada68 as these are fairly popular boards. Everyone and their mother seems to own one. I'd prefer to make some kind of announcement before doing this as people's QMK Configurator keymap jsons will break. I'm sure there are others but I wanted to make sure that non kbd.... boards are in fact kbdfans boards.

Well I still want to do this, any tips on how I should proceed?

@kb-elmo
Copy link
Contributor

kb-elmo commented Jan 8, 2022

Not sure if this makes sense.

The Tada68 is not a KBDfans PCB and was (and iirc still is) sold by many other companies like KPrepublic and some other AliExpress stores as well.
Moving it into the KBDfans directory could cause some confusion with users that got this PCB in a non-KBDfans keyboard.

@peepeetee
Copy link
Contributor Author

Not sure if this makes sense.

The Tada68 is not a KBDfans PCB and was (and iirc still is) sold by many other companies like KPrepublic and some other AliExpress stores as well. Moving it into the KBDfans directory could cause some confusion with users that got this PCB in a non-KBDfans keyboard.

Got it, Imma close this one then

@peepeetee peepeetee closed this Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants