Create KBDFans directory #5025
Merged
Create KBDFans directory #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de to readmes that was missing it
noroadsleft
requested changes
Jan 31, 2019
There was a problem hiding this comment.
DEFAULT_FOLDER uses the keyboards folder as its base.
KEYBOARD_<keyboard> preprocessor macros do the same.
If folders move, these have to be checked and updated to match the new folder structure.
These three changes will fix the compile job and Travis CI should pass.
diff --git a/keyboards/kbdfans/kbd75/kbd75.h b/keyboards/kbdfans/kbd75/kbd75.h
index 0798ad099..8e6f09450 100644
--- a/keyboards/kbdfans/kbd75/kbd75.h
+++ b/keyboards/kbdfans/kbd75/kbd75.h
@@ -3,11 +3,11 @@
#include "quantum.h"
-#ifdef KEYBOARD_kbd75_rev1
+#ifdef KEYBOARD_kbdfans_kbd75_rev1
#include "rev1.h"
#endif
-#ifdef KEYBOARD_kbd75_rev2
+#ifdef KEYBOARD_kbdfans_kbd75_rev2
#include "../rev1/rev1.h"
#include "rev2.h"
#endif
diff --git a/keyboards/kbdfans/kbd75/rules.mk b/keyboards/kbdfans/kbd75/rules.mk
index ae49271ab..5c4617131 100644
--- a/keyboards/kbdfans/kbd75/rules.mk
+++ b/keyboards/kbdfans/kbd75/rules.mk
@@ -1 +1 @@
-DEFAULT_FOLDER = kbd75/rev1
+DEFAULT_FOLDER = kbdfans/kbd75/rev1Every besides that looks good to me.
|
ahh crap, I thought I labeled this a WIP!! shoo shoo! |
…s already included in KBD75
…fference, condensing to one
…it out to the keyboard.c so everyone can partake.
|
@noroadsleft alright I think this has all the changes I wanted to do! |
vomindoraan
reviewed
Feb 2, 2019
noroadsleft
requested changes
Feb 2, 2019
Co-Authored-By: mechmerlin <30334081+mechmerlin@users.noreply.github.com>
noroadsleft
approved these changes
Feb 2, 2019
|
@mechmerlin This ready to be merged? |
@drashna yes it is! |
|
Thanks! |
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Feb 16, 2019
* move over kbd19x into the kbdfans directory * move over kbd4x into the kbdfans directory * move kbd66 into the kbdfans directory * move the kbd6x into the kbdfans directory * move kbd8x into the kbdfans directory * move kbd75 into the kbdfans directory * move kbd67 into kbdfans directory * add a fairly sparse readme for kbdfans directory * update make instructions for keyboards and add the Complete Newbs Guide to readmes that was missing it * get kbd75 compiling again * remove repetitive #defines of KC_NO and KC_TRNS when QMK_KEYBOARD_H is already included in KBD75 * add links to kbdfans readme * fix some readme formatting * there is no reason to have two different keymaps with such a small difference, condensing to one * turning on backlights by default * enable backlight by default for kbd66 * noticed that the kbd75 had caps lock led code in every keymap. Moved it out to the keyboard.c so everyone can partake. * Update keyboards/kbdfans/kbd66/readme.md Co-Authored-By: mechmerlin <30334081+mechmerlin@users.noreply.github.com> * update readme link ordering
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* move over kbd19x into the kbdfans directory * move over kbd4x into the kbdfans directory * move kbd66 into the kbdfans directory * move the kbd6x into the kbdfans directory * move kbd8x into the kbdfans directory * move kbd75 into the kbdfans directory * move kbd67 into kbdfans directory * add a fairly sparse readme for kbdfans directory * update make instructions for keyboards and add the Complete Newbs Guide to readmes that was missing it * get kbd75 compiling again * remove repetitive #defines of KC_NO and KC_TRNS when QMK_KEYBOARD_H is already included in KBD75 * add links to kbdfans readme * fix some readme formatting * there is no reason to have two different keymaps with such a small difference, condensing to one * turning on backlights by default * enable backlight by default for kbd66 * noticed that the kbd75 had caps lock led code in every keymap. Moved it out to the keyboard.c so everyone can partake. * Update keyboards/kbdfans/kbd66/readme.md Co-Authored-By: mechmerlin <30334081+mechmerlin@users.noreply.github.com> * update readme link ordering
|
This was referenced Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a kbdfans directory and moved in *most of their boards. This was done to better categorize and sort thru their boards. Not all of their boards begin with kbd.....
This will also allow us to use the
?filter=kbdfansin QMK Configurator to allow kbdfans to display an easily parse-able list of keyboards.Boards left out, are the dz60 and tada68 as these are fairly popular boards. Everyone and their mother seems to own one. I'd prefer to make some kind of announcement before doing this as people's QMK Configurator keymap jsons will break. I'm sure there are others but I wanted to make sure that non kbd.... boards are in fact kbdfans boards.
Types of changes
Issues Fixed or Closed by this PR
Checklist: