-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keyboard] jacky_studio/piggy60 #18012
Conversation
|
||
#pragma once | ||
|
||
#define LED_PIN_ON_STATE 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, just a heads up, you can use "on_state" as true/false under "indicators" in the json file to set this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering how I missed this, and the answer is that it's not in master
.
Will this PR be held until after the next breaking changes merge? I'll admit I was rushing to make it in under the wire, but if that's not gonna work out, I'll make that change. was pretty disappointing to have to add the config header for one define lmao
probably also worth noting; this feature isn't documented yet either. (I wouldn't mind submitting a PR for that if I can but as I understand it, develop
is closed for business...?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no worries, then.
And if it helps, develop is scheduled to be merged into master at the end of the month (in 2 weeks). Also, qmk.tzarc.io compiles firmware images from develop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving in current state, but noting the conversation had regarding indicators
Description
Adds Jacky's Piggy60 to QMK.
Types of Changes
Checklist