Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] jacky_studio/piggy60 refactor #18197

Merged
merged 3 commits into from
Aug 30, 2022
Merged

[Keyboard] jacky_studio/piggy60 refactor #18197

merged 3 commits into from
Aug 30, 2022

Conversation

lesshonor
Copy link
Contributor

Description

  • Better differentiates the hotswap and solder PCBs. The former only supports two of the eight-or-so non-_all layouts.
  • Adds necessary commas to the via keymap; without them qmk info -kb jacky_studio/piggy60 -km via fails.
  • Moves LED_PIN_ON_STATE to info.json as discussed previously.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@lesshonor
refactor jacky_studio/piggy60
34f12fe 
* differentiate the solder and hotswap versions

* move led_on_state to info.json

* add missing commas to via/keymap.json
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 28, 2022
@drashna drashna requested a review from a team August 28, 2022 20:18
fauxpark
fauxpark requested changes Aug 29, 2022
View reviewed changes
keyboards/jacky_studio/piggy60/info.json Outdated Show resolved Hide resolved
keyboards/jacky_studio/piggy60/solder/info.json Outdated Show resolved Hide resolved
@lesshonor lesshonor requested a review from fauxpark August 29, 2022 19:59
@drashna drashna merged commit 7eb71f7 into qmk:master Aug 30, 2022
@lesshonor lesshonor deleted the piggy60-fix branch August 30, 2022 03:03
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@lesshonor @nolanseaton
[Keyboard] jacky_studio/piggy60 refactor (qmk#18197)
2ec8e18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesshonor @drashna @fauxpark