Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Per Key LED Indicator Callbacks #18450

Merged
merged 15 commits into from
Oct 4, 2022
Merged

Fix Per Key LED Indicator Callbacks #18450

merged 15 commits into from
Oct 4, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Sep 21, 2022 •
edited
Loading

Description

They aren't boolean, so no good way to override them. This aims to fix that.

Also, removed old rgb matrix sleep code, in some cases (as it's deprecated)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 21, 2022
@drashna drashna marked this pull request as ready for review September 22, 2022 02:22
@drashna drashna requested a review from a team September 22, 2022 02:22
daskygit
daskygit requested changes Sep 22, 2022
View reviewed changes
keyboards/canary/canary60rgb/canary60rgb.c Outdated Show resolved Hide resolved
keyboards/keybee/keybee65/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/keychron/q2/rev_0113/keymaps/dhertz/keymap.c Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_poker/rev1/keymaps/ipetepete/keymap.c Outdated Show resolved Hide resolved
keyboards/tkc/portico/portico.c Outdated Show resolved Hide resolved
tzarc
tzarc requested changes Sep 22, 2022
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything Dasky said, too.

keyboards/planck/keymaps/gunp/keymap.c Outdated Show resolved Hide resolved
drashna and others added 8 commits September 22, 2022 10:23
@drashna @daskygit
Apply suggestions from code review
8ec87c4 
Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com>
@drashna @daskygit
Update keyboards/keybee/keybee65/keymaps/via/keymap.c
837c863 
Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com>
@drashna @daskygit
Update keyboards/tkc/portico/portico.c
7d6b413 
Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com>
@drashna @tzarc
Update keyboards/planck/keymaps/gunp/keymap.c
73197e0 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@drashna
Merge branch 'develop' into core/fix_per_key_callbacks
62289b8
@drashna
Merge branch 'develop' into core/fix_per_key_callbacks
4add657
@drashna
Add additional boards
2ce5f86
@drashna
Merge remote-tracking branch 'origin/develop' into core/fix_per_key_c…
0e1efc2 
…allbacks
This was referenced Sep 30, 2022
Closed
Merged
Closed
@drashna drashna merged commit 64b1ed4 into qmk:develop Oct 4, 2022
@drashna drashna deleted the core/fix_per_key_callbacks branch October 4, 2022 22:24
@waffle87 waffle87 mentioned this pull request Oct 5, 2022
Merged
8 tasks
andrebrait added a commit to andrebrait/qmk_firmware that referenced this pull request Oct 5, 2022
@andrebrait
[Keymap] Fix missing return value from changes introduced in qmk#18450
7dc93b7
@andrebrait andrebrait mentioned this pull request Oct 5, 2022
Merged
14 tasks
@drashna drashna mentioned this pull request Oct 25, 2022
Merged
14 tasks
This was referenced Nov 8, 2022
Merged
Merged
This was referenced Nov 15, 2022
Merged
Merged
Merged
Merged
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@drashna @daskygit
@tzarc @ramonimbao
Fix Per Key LED Indicator Callbacks (qmk#18450)
b997ca1 
Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com>
Co-authored-by: Nick Brassel <nick@tzarc.org>
eyuelt added a commit to eyuelt/qmk-keymaps that referenced this pull request Jan 5, 2024
@eyuelt
Update rgb indicator function return values as a result of
56c2c92 
qmk/qmk_firmware#18450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc requested changes

@daskygit daskygit daskygit approved these changes

Assignees
No one assigned
Labels
core documentation keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @tzarc @daskygit