[Keyboard] Add hardwareabstraction/handwire Board #18504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
drashna
requested changes
Sep 29, 2022
keyboards/hardwareabstraction/handwire/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/hardwareabstraction/handwire/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/hardwareabstraction/handwire/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/hardwareabstraction/handwire/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/hardwareabstraction/handwire/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
| #endif | ||
|
|
||
| #ifdef BUZZER_ENABLE | ||
| case KC_BZTOG: |
There was a problem hiding this comment.
Is there a reason for this extra code? It looks like it's a lot of duplication of the solenoid code.
And if that is the case, the solenoid code actually supports multiple pins. SOLENOID_PINS { E6, B2 } could be used.
There was a problem hiding this comment.
The reason I didn't declare another solenoid pin was because I want to be able to individually turn off the buzzer and the solenoid. From my knowledge, it didn't look like there was a way to turn off an individual pin while keeping the other one on.
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
|
If this is a handwired board, it should probably live under |
Evidentially I did not name this board that well. There's an actual PCB for it, but some of the components require some manual soldering. If a new name is needed / required I can help support that. |
keyboard-magpie
requested changes
Oct 2, 2022
Co-authored-by: Tom Barnes <barnestom@me.com>
Cgmandy
requested review from
keyboard-magpie and
drashna
and removed request for
keyboard-magpie
keyboard-magpie
approved these changes
Oct 4, 2022
drashna
requested changes
Oct 5, 2022
keyboards/hardwareabstraction/handwire/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
drashna
reviewed
Oct 10, 2022
drashna
requested changes
Oct 10, 2022
Co-authored-by: Drashna Jaelre <drashna@live.com>
drashna
approved these changes
Oct 10, 2022
…k_firmware into hardwareabstraction-keyboards
6 tasks
SjB
added a commit
to SjB/qmk_firmware
that referenced
this pull request
Oct 13, 2022
* upstream/master: Remove xealousbrown keyboard (qmk#18658) Bugfix waffling60 rev d solder (qmk#18673) [Keyboard] Add hardwareabstraction/handwire Board (qmk#18504) Vertex AngleR2 Layout Refactor (qmk#18661) [Keyboard][Keymap] Fix random keys being sent on Mac + userspace changes (qmk#15648) [Keyboard] New IDOBAO ID61 (a.k.a. Denwir D60) (qmk#17362) [Keyboard] Add ANAVI Macro Pad 10 (qmk#18620) Fix future naming collisions. (qmk#18645) Synth Labs Solo Configurator Fixes (qmk#18642) Update CRKBD keymap (qmk#18619) Remove all `BACKLIGHT_LEVELS 0` (qmk#18630) DD mappings for build.debounce_type and backlight.levels (qmk#18628) Add encoder map support for Keychron Q1v1 and Q2 (qmk#18598) Studio Kestra Nascent Refactor (qmk#18625) [Keyboard] Add supersplit (qmk#18611)
quinnyo
pushed a commit
to quinnyo/qmk_firmware
that referenced
this pull request
Oct 21, 2022
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Tom Barnes <barnestom@me.com>
aivalja
pushed a commit
to aivalja/qmk_firmware
that referenced
this pull request
Nov 7, 2022
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Tom Barnes <barnestom@me.com>
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Tom Barnes <barnestom@me.com>
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Tom Barnes <barnestom@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for handwire board. Utilizes ATMEGA32u4 microcontroller with a default and via keymap./
Keyboard features an OLED display, Solenoid, and Active Buzzer
Types of Changes
Issues Fixed or Closed by This PR
Checklist