Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix future naming collisions. #18645

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Fix future naming collisions. #18645

merged 1 commit into from
Oct 8, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Oct 8, 2022

Description

Pre-emptively handle naming conflicts with #18643.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team October 8, 2022 04:50
@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Oct 8, 2022
@tzarc tzarc merged commit 7b3ad56 into qmk:master Oct 8, 2022
@tzarc tzarc deleted the elephant42-naming branch October 8, 2022 04:52
SjB added a commit to SjB/qmk_firmware that referenced this pull request Oct 13, 2022
@SjB
Merge remote-tracking branch 'upstream/master' into sjb/all-keyboard
3e929d4 
* upstream/master:
  Remove xealousbrown keyboard (qmk#18658)
  Bugfix waffling60 rev d solder (qmk#18673)
  [Keyboard] Add hardwareabstraction/handwire Board  (qmk#18504)
  Vertex AngleR2 Layout Refactor (qmk#18661)
  [Keyboard][Keymap] Fix random keys being sent on Mac + userspace changes (qmk#15648)
  [Keyboard] New IDOBAO ID61 (a.k.a. Denwir D60) (qmk#17362)
  [Keyboard] Add ANAVI Macro Pad 10 (qmk#18620)
  Fix future naming collisions. (qmk#18645)
  Synth Labs Solo Configurator Fixes (qmk#18642)
  Update CRKBD keymap (qmk#18619)
  Remove all `BACKLIGHT_LEVELS 0` (qmk#18630)
  DD mappings for build.debounce_type and backlight.levels (qmk#18628)
  Add encoder map support for Keychron Q1v1 and Q2 (qmk#18598)
  Studio Kestra Nascent Refactor (qmk#18625)
  [Keyboard] Add supersplit (qmk#18611)
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
@tzarc @quinnyo
Fix future naming collisions. (qmk#18645)
6b2764a
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@tzarc
Fix future naming collisions. (qmk#18645)
9503db0
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@tzarc @ramonimbao
Fix future naming collisions. (qmk#18645)
c11e3aa
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@tzarc @nolanseaton
Fix future naming collisions. (qmk#18645)
e4d377c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @fauxpark @zvecr