Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly build keymap.json containing additional config #18766

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Correctly build keymap.json containing additional config #18766

merged 3 commits into from
Oct 19, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 19, 2022 •
edited
Loading

Description

The following does not correctly build a via compatible keymap

qmk compile keyboards/thevankeyboards/minivan/keymaps/via/keymap.json

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Oct 19, 2022
@zvecr zvecr requested a review from a team October 19, 2022 00:36
@github-actions github-actions bot added cli qmk cli command python labels Oct 19, 2022
@zvecr zvecr merged commit fc0330a into qmk:develop Oct 19, 2022
@zvecr zvecr mentioned this pull request Oct 19, 2022
Merged
14 tasks
@precondition precondition mentioned this pull request Oct 24, 2022
Closed
3 tasks
@zvecr zvecr deleted the feature/correctly_build_dd_keymap branch November 23, 2022 19:35
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Correctly build keymap.json containing additional config (qmk#18766)
7e04340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark