Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly build out of tree keymap.json containing additional config #18775

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Correctly build out of tree keymap.json containing additional config #18775

merged 1 commit into from
Oct 19, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 19, 2022 •
edited
Loading

Description

Missed when implementing #18766.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Oct 19, 2022
@zvecr zvecr changed the title Build correctly when out of tree Correctly build out of tree keymap.json containing additional config Oct 19, 2022
@zvecr zvecr requested a review from a team October 19, 2022 15:33
@zvecr zvecr merged commit aa8e0a3 into qmk:develop Oct 19, 2022
@zvecr zvecr deleted the feature/correctly_build_dd_keymap2 branch October 19, 2022 16:47
@zvecr zvecr added the bug label Oct 19, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Build correctly when out of tree (qmk#18775)
b5d1181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark