Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix Cain RE Touch-Up #20719

Merged
merged 6 commits into from
May 8, 2023
Merged

Conversation

noroadsleft
Copy link
Member

Description

  • add layout/matrix diagram
  • correct layout data

Unfortunately I haven't been able to find high-resolution images of the PCB to investigate the layout support, and there doesn't seem to be any VIA-type data anywhere. (I think the PCB pre-dates VIA, to be fair.)

cc @yulei (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

The PCB supports multiple layouts, but I have not been able to discover how the additional layouts are wired.
@noroadsleft
Copy link
Member Author

Note: This PR is in a ready-to-merge state, but I hope to get some guidance as to what to do about

⚠ matrix/cain_re: "LAYOUT_all" should be "LAYOUT" unless additional layouts are provided.

@noroadsleft noroadsleft marked this pull request as ready for review May 4, 2023 22:46
@yulei
Copy link
Contributor

yulei commented May 7, 2023

cain_re.pdf
thanks for your work, this was the schema for the avr based cain pcb @noroadsleft

@github-actions github-actions bot added the keymap label May 8, 2023
@noroadsleft
Copy link
Member Author

@yulei,

Thanks for the electrical schematic. That got me what I was after. :)

@noroadsleft noroadsleft merged commit 20362a9 into qmk:develop May 8, 2023
@noroadsleft noroadsleft deleted the kb_layouts/matrix_cain_re branch May 8, 2023 07:00
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
* add matrix_diagram.md

* info.json: apply friendly formatting

* info.json: correct layout data

* info.json: alias LAYOUT to LAYOUT_all

The PCB supports multiple layouts, but I have not been able to discover how the additional layouts are wired.

* update matrix_diagram.md (thanks yulei)

* add LAYOUT_2u_numpad_plus_enter_zero with reference keymap
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
* add matrix_diagram.md

* info.json: apply friendly formatting

* info.json: correct layout data

* info.json: alias LAYOUT to LAYOUT_all

The PCB supports multiple layouts, but I have not been able to discover how the additional layouts are wired.

* update matrix_diagram.md (thanks yulei)

* add LAYOUT_2u_numpad_plus_enter_zero with reference keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants