Allow force flush of oled display. #20953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API copmatible refactoring of the oled_render function that allows callers to forcibly render all dirty blocks instead of allowing the oled_task function to render them asynchronously. This is mostly useful when want to display a logo/message/graphic right before rebooting into a bootloader or other state where the MCU will be unable to finish flushing blocks to the display.
arlaneenalra
commented
May 14, 2023
| @@ -235,15 +263,15 @@ So those precalculated arrays just index the memory offsets in the order in whic | |||
| ## OLED API | |||
|
|
|||
| ```c | |||
| // OLED rotation enum values are flags | |||
| // OLED Rotation enum values are flags | |||
There was a problem hiding this comment.
I recopied the relevant chunk of the .h file. That's where the other changes came from.
drashna
requested changes
May 15, 2023
arlaneenalra
commented
May 15, 2023
drashna
reviewed
May 16, 2023
|
Of course ... I'll get that fixed. Anything else while I'm at it?
…On Tue, May 16, 2023, 10:23 Drashna Jaelre ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In drivers/oled/oled_driver.h
<#20953 (comment)>:
> @@ -353,8 +353,12 @@ oled_rotation_t oled_init_user(oled_rotation_t rotation);
// Clears the display buffer, resets cursor position to 0, and sets the buffer to dirty for rendering
void oled_clear(void);
-// Renders the dirty chunks of the buffer to oled display
-void oled_render(void);
+// Alias to olde_render_dirty to avoid a change in api.
⬇️ Suggested change
-// Alias to olde_render_dirty to avoid a change in api.
+// Alias to oled_render_dirty to avoid a change in api.
—
Reply to this email directly, view it on GitHub
<#20953 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACYAP7C2LYFDAJABM3RQBDXGOLWHANCNFSM6AAAAAAYBOV4CQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
drashna
reviewed
May 16, 2023
Co-authored-by: Drashna Jaelre <drashna@live.com>
drashna
approved these changes
May 17, 2023
|
One last question ... does the mr get floated until Q3 or will it show up in a working/dev branch earlier? Mainly trying to think through some other ideas and how to handle them in the fork for my keyboard .. |
fauxpark
requested changes
May 17, 2023
Incorporating other docs updates .. Co-authored-by: Ryan <fauxpark@gmail.com>
…re into oled-refactor-mr
Q3 starts in a couple of weeks. Namely, this has missed the cuttoff: |
14 tasks
zvecr
approved these changes
Sep 6, 2023
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Oct 25, 2023
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>
christrotter
pushed a commit
to christrotter/qmk_firmware
that referenced
this pull request
Nov 28, 2023
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>
zgagnon
pushed a commit
to zgagnon/qmk_firmware_waterfowl
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>
future-figs
pushed a commit
to future-figs/qmk_firmware
that referenced
this pull request
Dec 27, 2023
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
API copmatible refactoring of the oled_render function that allows callers to forcibly render all dirty
blocks instead of allowing the oled_task function to render them asynchronously. This is mostly useful
when want to display a logo/message/graphic right before rebooting into a bootloader or other state
where the MCU will be unable to finish flushing blocks to the display.
Types of Changes
Checklist