-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of QVEX Lynepad implementation #20975
Conversation
Can we get this merged into develop before the May develop->master merge? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get this merged into develop before the May develop->master merge?
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the PR checklist:
info.json
- With the move to data driven keyboard configuration, we encourage contributors to utilise as many features as possible of the info.json schema.
The docs do have a lot of information on how to do it the old way—not everyone is running a recent version of QMK, for one thing. But new submissions will need to adhere to newer guidelines.
Thank you @lesshonor for the thorough suggestions. I would like to make QMK a default firmware for the QVEX Lynepad. Is there a way to get it merged into master before the end of Q3 ? I suppose the maintainers could make an exception on the cut-off date of the develop branch as the reason for this getting merged into develop is just
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough about custom matrix wiring to provide any worthwhile analysis there. Seems fine to me. Good luck.
@@ -1,13 +1,34 @@ | |||
# QVEX Lynepad | |||
|
|||
Macro pad with 11 keys and 2 rotary encoders. | |||
![QVEX Lynepad](https://qvex.eu/img/lynepad.jpg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A collaborator may ask you to rehost this on a dedicated image-hosting service, but since long-time suggestion imgur is circling the drain I'm going to defer that to them. Just wanted to warn you.
* Keyboard Maintainer: [KemoNine](https://git.kemonine.info/kemonine/keyboard) | ||
* Hardware Supported: QVEX Lynepad: macro keypad | ||
* Hardware Availability: Tindie [Keyboard Kit](https://www.tindie.com/products/qvex_tech/qvex-lynepad-macro-keypad/) | ||
*Macropad with 11 keys, thumbwheel, and a rotary 4-way switch* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Macropad with 11 keys, thumbwheel, and a rotary 4-way switch* | |
Macropad with 11 keys, thumbwheel, and a rotary 4-way switch |
No need for the italics -- they're only in the template to try and bring attention to a line that should be replaced (...submissions often overlook the readme)
Closing as bot would have closed this ages ago, has conflicts, and would require a fair amount of changes to meet the current PR checklist. |
Description
Rework of QVEX Lynepad implementation:
Types of Changes
Issues Fixed or Closed by This PR
#20493
Checklist