Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of QVEX Lynepad implementation #20975

Closed
wants to merge 11 commits into from
Closed

Conversation

seflm
Copy link
Contributor

@seflm seflm commented May 17, 2023

Description

Rework of QVEX Lynepad implementation:

  • Full VIA support (including encoders, and 4-way switch)
  • Proper support of off-matrix 4-way switch using "virtual" rows
  • Use RGB ring as layer indicator
  • Retaining the original keymap of @mcrosson

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

#20493

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 17, 2023
@seflm
Copy link
Contributor Author

seflm commented May 17, 2023

Can we get this merged into develop before the May develop->master merge? Thank you

Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get this merged into develop before the May develop->master merge?

Probably not.

keyboards/qvex/lynepad/config.h Show resolved Hide resolved
keyboards/qvex/lynepad/info.json Outdated Show resolved Hide resolved
keyboards/qvex/lynepad/config.h Outdated Show resolved Hide resolved
keyboards/qvex/lynepad/readme.md Outdated Show resolved Hide resolved
keyboards/qvex/lynepad/readme.md Outdated Show resolved Hide resolved
keyboards/qvex/lynepad/rules.mk Outdated Show resolved Hide resolved
keyboards/qvex/lynepad/matrix.c Outdated Show resolved Hide resolved
keyboards/qvex/lynepad/info.json Outdated Show resolved Hide resolved
seflm and others added 4 commits May 18, 2023 08:52
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@seflm seflm requested a review from lesshonor May 18, 2023 07:19
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the PR checklist:

  • info.json
    • With the move to data driven keyboard configuration, we encourage contributors to utilise as many features as possible of the info.json schema.

The docs do have a lot of information on how to do it the old way—not everyone is running a recent version of QMK, for one thing. But new submissions will need to adhere to newer guidelines.

keyboards/qvex/lynepad/config.h Outdated Show resolved Hide resolved
keyboards/qvex/lynepad/info.json Outdated Show resolved Hide resolved
keyboards/qvex/lynepad/rules.mk Outdated Show resolved Hide resolved
keyboards/qvex/lynepad/info.json Show resolved Hide resolved
keyboards/qvex/lynepad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/qvex/lynepad/keymaps/mcrosson/keymap.c Outdated Show resolved Hide resolved
keyboards/qvex/lynepad/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/qvex/lynepad/info.json Show resolved Hide resolved
@seflm
Copy link
Contributor Author

seflm commented May 19, 2023

Thank you @lesshonor for the thorough suggestions.

I would like to make QMK a default firmware for the QVEX Lynepad. Is there a way to get it merged into master before the end of Q3 ? I suppose the maintainers could make an exception on the cut-off date of the develop branch as the reason for this getting merged into develop is just to reduce master -> develop merge conflicts. Or we could merge this into master directly as another qvex keyboard (something like lynepad_via) to comply with the PR?

keyboard updates and refactors (eg. to data driven) must go through develop to reduce master -> develop merge conflicts

@seflm seflm requested a review from lesshonor May 19, 2023 10:01
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about custom matrix wiring to provide any worthwhile analysis there. Seems fine to me. Good luck.

@@ -1,13 +1,34 @@
# QVEX Lynepad

Macro pad with 11 keys and 2 rotary encoders.
![QVEX Lynepad](https://qvex.eu/img/lynepad.jpg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A collaborator may ask you to rehost this on a dedicated image-hosting service, but since long-time suggestion imgur is circling the drain I'm going to defer that to them. Just wanted to warn you.

* Keyboard Maintainer: [KemoNine](https://git.kemonine.info/kemonine/keyboard)
* Hardware Supported: QVEX Lynepad: macro keypad
* Hardware Availability: Tindie [Keyboard Kit](https://www.tindie.com/products/qvex_tech/qvex-lynepad-macro-keypad/)
*Macropad with 11 keys, thumbwheel, and a rotary 4-way switch*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Macropad with 11 keys, thumbwheel, and a rotary 4-way switch*
Macropad with 11 keys, thumbwheel, and a rotary 4-way switch

No need for the italics -- they're only in the template to try and bring attention to a line that should be replaced (...submissions often overlook the readme)

@tzarc tzarc changed the base branch from develop to master May 28, 2023 21:49
@seflm seflm marked this pull request as draft June 22, 2023 12:02
@zvecr
Copy link
Member

zvecr commented Jul 5, 2024

Closing as bot would have closed this ages ago, has conflicts, and would require a fair amount of changes to meet the current PR checklist.

@zvecr zvecr closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants