Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RGBLIGHT_HUE/SAT/VAL_STEP to data driven #21292

Merged
merged 9 commits into from
Jun 24, 2023
Merged

Move RGBLIGHT_HUE/SAT/VAL_STEP to data driven #21292

merged 9 commits into from
Jun 24, 2023

Conversation

fauxpark
Copy link
Member

Description

RGBLIGHT_HUE_STEP -> rgblight.hue_steps
RGBLIGHT_SAT_STEP -> rgblight.saturation.steps
RGBLIGHT_VAL_STEP -> rgblight.brightness_steps

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 19, 2023 00:10
@fauxpark fauxpark changed the title Remove commented defines Move RGBLIGHT_HUE/SAT/VAL_STEP to data driven Jun 19, 2023
@fauxpark
Copy link
Member Author

Only SHA mismatch is ergodox_ez/shine, due to the removal of RGBLIGHT_SAT_STEP 255, which seemed not very useful.

@fauxpark fauxpark mentioned this pull request Jun 19, 2023
Closed
14 tasks
@tzarc tzarc merged commit 4ae9bfd into qmk:develop Jun 24, 2023
@fauxpark fauxpark deleted the rgblight-hsv-step-data-driven branch June 24, 2023 07:38
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@fauxpark @tzarc @jesperhellberg
Move RGBLIGHT_HUE/SAT/VAL_STEP to data driven (qmk#21292)
f7b252b 
Co-authored-by: Nick Brassel <nick@tzarc.org>
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@fauxpark @tzarc @thismarvin
Move RGBLIGHT_HUE/SAT/VAL_STEP to data driven (qmk#21292)
1db4008 
Co-authored-by: Nick Brassel <nick@tzarc.org>
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@fauxpark @tzarc @akeep
Move RGBLIGHT_HUE/SAT/VAL_STEP to data driven (qmk#21292)
a61817b 
Co-authored-by: Nick Brassel <nick@tzarc.org>
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@fauxpark @tzarc @csolje
Move RGBLIGHT_HUE/SAT/VAL_STEP to data driven (qmk#21292)
d4d581b 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@jpskenn jpskenn mentioned this pull request Nov 2, 2023
Open
39 tasks
jpskenn added a commit to jpskenn/qmk_firmware that referenced this pull request Nov 3, 2023
@jpskenn
Move RGBLIGHT_HUE/SAT/VAL_STEP to data driven (qmk#21292)
23b82ce 
RGBLIGHT_HUEとかをinfo.jsonへ。
VALはデフォルト値のため、喜寿せず。
jpskenn added a commit to jpskenn/qmk_firmware that referenced this pull request Nov 5, 2023
@jpskenn
Move RGBLIGHT_HUE/SAT/VAL_STEP to data driven (qmk#21292)
08aaaff
jashort pushed a commit to jashort/qmk_firmware that referenced this pull request Nov 20, 2023
@fauxpark @tzarc @jashort
Move RGBLIGHT_HUE/SAT/VAL_STEP to data driven (qmk#21292)
7e89891 
Co-authored-by: Nick Brassel <nick@tzarc.org>
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@fauxpark @tzarc @autoferrit
Move RGBLIGHT_HUE/SAT/VAL_STEP to data driven (qmk#21292)
4669c0c 
Co-authored-by: Nick Brassel <nick@tzarc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @tzarc