Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Fix VID and PID for AnnePro2 #22263

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

zv0n
Copy link
Contributor

@zv0n zv0n commented Oct 12, 2023

Fix of the AnnePro2's VID and PID

Description

I have changed AnnePro2's VID and PID to the original firmware's values, so it can be used with VIA (0xFEED is invalid VendorId).

I got the original values from AnnePro2-Tools website - https://openannepro.github.io/ap2_revisions/

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zv0n
Copy link
Contributor Author

zv0n commented Oct 12, 2023

It seems the CI is failing on files that I have not touched, how should I proceed here?

@drashna
Copy link
Member

drashna commented Oct 14, 2023

It seems the CI is failing on files that I have not touched, how should I proceed here?

That's fine.

Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems pretty reasonable

@@ -3,7 +3,7 @@
"url": "https://openannepro.github.io/",
"maintainer": "bwisn",
"usb": {
"vid": "0xFEED",
"vid": "0x04D9",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, this looks to be holtek's VID. 0xAC20 would be better, I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like it, however it looks like Obins borrowed the VID, I even found it referenced in SDL - https://github.com/libsdl-org/SDL/blob/main/src/joystick/SDL_joystick.c

So if we want to keep the same VID/PID as the original keyboard, I think 0x04D9 is fine

However I'd understand if you want to change the VID to differentiate between the original keyboard and one with QMK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drashna I've changed the VID assuming we want to differentiate QMK from the original keyboard (if we don't want to differentiate, we should switch it back)

@drashna drashna requested a review from a team December 12, 2023 08:56
@tzarc tzarc merged commit 744ac91 into qmk:develop Jan 9, 2024
2 of 3 checks passed
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants