-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keyboard] Fix VID and PID for AnnePro2 #22263
Conversation
It seems the CI is failing on files that I have not touched, how should I proceed here? |
That's fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems pretty reasonable
keyboards/annepro2/info.json
Outdated
@@ -3,7 +3,7 @@ | |||
"url": "https://openannepro.github.io/", | |||
"maintainer": "bwisn", | |||
"usb": { | |||
"vid": "0xFEED", | |||
"vid": "0x04D9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, this looks to be holtek's VID. 0xAC20
would be better, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks like it, however it looks like Obins borrowed the VID, I even found it referenced in SDL - https://github.com/libsdl-org/SDL/blob/main/src/joystick/SDL_joystick.c
So if we want to keep the same VID/PID as the original keyboard, I think 0x04D9 is fine
However I'd understand if you want to change the VID to differentiate between the original keyboard and one with QMK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drashna I've changed the VID assuming we want to differentiate QMK from the original keyboard (if we don't want to differentiate, we should switch it back)
Fix of the AnnePro2's VID and PID
Description
I have changed AnnePro2's VID and PID to the original firmware's values, so it can be used with VIA (0xFEED is invalid VendorId).
I got the original values from AnnePro2-Tools website - https://openannepro.github.io/ap2_revisions/
Types of Changes
Checklist