Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate true/false for _DEFAULT_ON options #22829

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Generate true/false for _DEFAULT_ON options #22829

merged 1 commit into from
Jan 6, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 5, 2024 •
edited
Loading

Description

Currently the codegen for the various _DEFAULT_ON values is broken.

To distinguish the 2 different output formats, a new type has been added to mapping.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command dd Data Driven Changes labels Jan 5, 2024
@zvecr zvecr added the bug label Jan 5, 2024
@fauxpark
Copy link
Member

fauxpark commented Jan 5, 2024

+1 for "flag"

@zvecr zvecr marked this pull request as ready for review January 5, 2024 13:40
@zvecr zvecr merged commit 71257e2 into qmk:develop Jan 6, 2024
4 of 5 checks passed
@zvecr zvecr deleted the fix_default_on branch January 6, 2024 13:16
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@zvecr @itsjonny96
Generate true/false for _DEFAULT_ON options (qmk#22829)
eab8c6e
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@zvecr @mechlovin
Generate true/false for _DEFAULT_ON options (qmk#22829)
6ba3210
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@zvecr @mechlovin
Generate true/false for _DEFAULT_ON options (qmk#22829)
c759d44
@evils evils mentioned this pull request Feb 26, 2024
Closed
14 tasks
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Generate true/false for _DEFAULT_ON options (qmk#22829)
3c45370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug cli qmk cli command dd Data Driven Changes python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark