Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data driven split serial implementation #23149

Closed
wants to merge 3 commits into from
Closed

Conversation

evils
Copy link

@evils evils commented Feb 25, 2024

Description

basically the remaining changes of #17959 after a year of keeping my local changes in sync

these are my local changes i needed to get a pi pico based handwired tbk mini working

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • none i could find

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the dd Data Driven Changes label Feb 25, 2024
@zvecr zvecr changed the base branch from master to develop February 25, 2024 06:01
@evils
Copy link
Author

evils commented Feb 26, 2024

didn't see that the change of PR base resulted in a merge conflict
i've resolved that

if i understood #22829 correctly, define flags that don't need a true / false value but just need to exist or not, should be of type flag in info_config.hjson

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Apr 14, 2024
@evils
Copy link
Author

evils commented Apr 27, 2024

this PR's not stale, i intend to keep it mergible
though it is waiting for the json interface to be solidified more formally
which may make this work obsolete

and i have no idea what the CI failure is due to

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Apr 28, 2024
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 12, 2024
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dd Data Driven Changes stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant