Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New keyboard: QWERTYYdox #3636

Merged
merged 17 commits into from
Aug 19, 2018
Merged

New keyboard: QWERTYYdox #3636

merged 17 commits into from
Aug 19, 2018

Conversation

aydenvis
Copy link
Contributor

I'm not great at Github, so I apologize in advance.

Handwired split 40% with two Y keys and three thumb keys.

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this looks to use to use the normal Split code.

We recently added "split common" which handles all of that stuff, as a core component.

To implement that, you'd remove the split util, i2c, serial and matrix files. Remove the SRC lines in the rules.mk, and replace CUSTOM_MATRIX = yes with SPLIT_KEYBOARD = yes.

This is optional, though. But doing so would mean that you benefit from the split code stuff (such as synced backlighting, synced rgb (static, no animations), and any other improvements made to it, in the future.

@@ -0,0 +1,3 @@
ifndef QUANTUM_DIR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block isn't needed, and is a holdover from the old makefile system.

Please remove it

along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#ifndef CONFIG_USER_H
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace the boilerplate with #pragma once?

Eg, replace this:

#ifndef CONFIG_USER_H
#define CONFIG_USER_H

#include "config_common.h"

with just #pragma once, and remove the #endif at the end

@aydenvis
Copy link
Contributor Author

@drashna Everything should be fixed.

#ifndef REV1_CONFIG_H
#define REV1_CONFIG_H

#include QMK_KEYBOARD_CONFIG_H
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this line with #include "config_common.h". That should fix the compile errers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@aydenvis
Copy link
Contributor Author

@drashna Done.

@drashna
Copy link
Member

drashna commented Aug 19, 2018

Awesome, thanks!

@drashna drashna merged commit 4cc1edb into qmk:master Aug 19, 2018
alexey-danilov pushed a commit to alexey-danilov/qmk_firmware that referenced this pull request Sep 6, 2018
* Add files via upload

* Update readme.md

* Update readme.md

* Update readme.md

* Add files via upload

* Delete split_util.h

* Delete split_util.c

* Delete serial.h

* Delete serial.c

* Delete matrix.c

* Delete i2c.h

* Delete i2c.c

* Update rules.mk

* Update config.h

* Update readme.md

* Update readme.md
ChrissiQ pushed a commit to ChrissiQ/qmk_firmware that referenced this pull request Sep 25, 2018
* Add files via upload

* Update readme.md

* Update readme.md

* Update readme.md

* Add files via upload

* Delete split_util.h

* Delete split_util.c

* Delete serial.h

* Delete serial.c

* Delete matrix.c

* Delete i2c.h

* Delete i2c.c

* Update rules.mk

* Update config.h

* Update readme.md

* Update readme.md
yamad pushed a commit to yamad/qmk_firmware that referenced this pull request Apr 10, 2019
* Add files via upload

* Update readme.md

* Update readme.md

* Update readme.md

* Add files via upload

* Delete split_util.h

* Delete split_util.c

* Delete serial.h

* Delete serial.c

* Delete matrix.c

* Delete i2c.h

* Delete i2c.c

* Update rules.mk

* Update config.h

* Update readme.md

* Update readme.md
@noroadsleft noroadsleft mentioned this pull request Jul 30, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants