-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New keyboard: QWERTYYdox #3636
New keyboard: QWERTYYdox #3636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this looks to use to use the normal Split code.
We recently added "split common" which handles all of that stuff, as a core component.
To implement that, you'd remove the split util, i2c, serial and matrix files. Remove the SRC lines in the rules.mk, and replace CUSTOM_MATRIX = yes
with SPLIT_KEYBOARD = yes
.
This is optional, though. But doing so would mean that you benefit from the split code stuff (such as synced backlighting, synced rgb (static, no animations), and any other improvements made to it, in the future.
@@ -0,0 +1,3 @@ | |||
ifndef QUANTUM_DIR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block isn't needed, and is a holdover from the old makefile system.
Please remove it
along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
#ifndef CONFIG_USER_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you replace the boilerplate with #pragma once
?
Eg, replace this:
#ifndef CONFIG_USER_H
#define CONFIG_USER_H
#include "config_common.h"
with just #pragma once
, and remove the #endif
at the end
@drashna Everything should be fixed. |
keyboards/qwertyydox/config.h
Outdated
#ifndef REV1_CONFIG_H | ||
#define REV1_CONFIG_H | ||
|
||
#include QMK_KEYBOARD_CONFIG_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this line with #include "config_common.h"
. That should fix the compile errers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@drashna Done. |
Awesome, thanks! |
* Add files via upload * Update readme.md * Update readme.md * Update readme.md * Add files via upload * Delete split_util.h * Delete split_util.c * Delete serial.h * Delete serial.c * Delete matrix.c * Delete i2c.h * Delete i2c.c * Update rules.mk * Update config.h * Update readme.md * Update readme.md
* Add files via upload * Update readme.md * Update readme.md * Update readme.md * Add files via upload * Delete split_util.h * Delete split_util.c * Delete serial.h * Delete serial.c * Delete matrix.c * Delete i2c.h * Delete i2c.c * Update rules.mk * Update config.h * Update readme.md * Update readme.md
* Add files via upload * Update readme.md * Update readme.md * Update readme.md * Add files via upload * Delete split_util.h * Delete split_util.c * Delete serial.h * Delete serial.c * Delete matrix.c * Delete i2c.h * Delete i2c.c * Update rules.mk * Update config.h * Update readme.md * Update readme.md
I'm not great at Github, so I apologize in advance.
Handwired split 40% with two Y keys and three thumb keys.