QWERTYYdox refactor #6446
Merged
QWERTYYdox refactor #6446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`__` key in keymap.c doesn't actually exist on the physical hardware. Removed key from keymap.c and removed its argument from the layout macro.
It makes the keymap pretty.
- convert to pragma once include guard - remove redundant definitions - remove commented code blocks
Was copied from ergotravel; not valid for this keyboard.
Previous codebase enabled Backlight at keyboard level then disabled it at revision level.
Aligns the keyboard-level config.h file more closely with the current QMK template for AVR keyboards.
|
Does this mean that the QWERTTYdox files are fully up to date with the latest split firmware? |
aydenvis
approved these changes
Jul 30, 2019
Yes. You were already using the Split Common architecture (enabled via Pretty much all of these changes are coding convention and implementation details. Realistically, as you only have one revision, you don't actually need the Ideally for this keyboard, all of the code should have been in
You're welcome, friend. |
raymond-w-ko
pushed a commit
to raymond-w-ko/qmk_firmware
that referenced
this pull request
Aug 4, 2019
* Delete null key `__` key in keymap.c doesn't actually exist on the physical hardware. Removed key from keymap.c and removed its argument from the layout macro. * Delete unused keycode aliases * Replace layer index definitions with an enum * Replace redundant numpad keycodes with native aliases * Use native layer change keycodes instead of aliases * Visually align the keycodes It makes the keymap pretty. * Correct Configurator layout data * Clean up header files - convert to pragma once include guard - remove redundant definitions - remove commented code blocks * Delete LAYOUT_kc macro Was copied from ergotravel; not valid for this keyboard. * Consolidate rev1 rules.mk settings to keyboard level Previous codebase enabled Backlight at keyboard level then disabled it at revision level. * Delete unused rules * Consolidate config.h settings from keymap level to keyboard level * Modernize keyboard's config.h file Aligns the keyboard-level config.h file more closely with the current QMK template for AVR keyboards.
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Aug 6, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (240 commits) Move maartenwut's keyboards to one folder (qmk#6484) GH60 Refactor: Move Satan into GH60 directory (qmk#6485) Remove unused _BOOTLOADER defines [Keyboard] add keyboard-discipline (qmk#6464) [Split] Add config option for DIRECT_PINS_RIGHT (qmk#6479) [Keymap] Add some more commonly used symbols to melody96/zunger. (qmk#6478) [Keyboard] WT75-A & WT75-B fixes for QMK Configurator (qmk#6472) [Keymap] update to dsanchezseco keymap (qmk#6470) [Keymap] Fixed Tanuki RGB lighting (qmk#6462) Add iS0 Keypad (qmk#6456) [Keymap] jotix ortho_4x12_layout (qmk#6458) [Keyboard] New Keyboard: KBDPad MKI (qmk#6452) [Keymap] Adds Keymap for Iris/blucky (qmk#6449) [Keymap] Fixing Sol Rev2 default keymap OLED rotation. (qmk#6448) [Keyboard] QWERTYYdox refactor (qmk#6446) [Keymap] Adds keymap for muzfuz/lunar (qmk#6432) [Docs] Add dfu-util and caterina udev examples (qmk#6429) updates to akb/raine in ready for production units (qmk#6457) Removed print call to resolve qmk#6364 (qmk#6413) Fix typo for building Ergodox EZ keyboards (qmk#6453) ...
doughsay
pushed a commit
to doughsay/qmk_firmware
that referenced
this pull request
Aug 31, 2019
* Delete null key `__` key in keymap.c doesn't actually exist on the physical hardware. Removed key from keymap.c and removed its argument from the layout macro. * Delete unused keycode aliases * Replace layer index definitions with an enum * Replace redundant numpad keycodes with native aliases * Use native layer change keycodes instead of aliases * Visually align the keycodes It makes the keymap pretty. * Correct Configurator layout data * Clean up header files - convert to pragma once include guard - remove redundant definitions - remove commented code blocks * Delete LAYOUT_kc macro Was copied from ergotravel; not valid for this keyboard. * Consolidate rev1 rules.mk settings to keyboard level Previous codebase enabled Backlight at keyboard level then disabled it at revision level. * Delete unused rules * Consolidate config.h settings from keymap level to keyboard level * Modernize keyboard's config.h file Aligns the keyboard-level config.h file more closely with the current QMK template for AVR keyboards.
swanmatch
pushed a commit
to swanmatch/qmk_firmware
that referenced
this pull request
Sep 3, 2019
* Delete null key `__` key in keymap.c doesn't actually exist on the physical hardware. Removed key from keymap.c and removed its argument from the layout macro. * Delete unused keycode aliases * Replace layer index definitions with an enum * Replace redundant numpad keycodes with native aliases * Use native layer change keycodes instead of aliases * Visually align the keycodes It makes the keymap pretty. * Correct Configurator layout data * Clean up header files - convert to pragma once include guard - remove redundant definitions - remove commented code blocks * Delete LAYOUT_kc macro Was copied from ergotravel; not valid for this keyboard. * Consolidate rev1 rules.mk settings to keyboard level Previous codebase enabled Backlight at keyboard level then disabled it at revision level. * Delete unused rules * Consolidate config.h settings from keymap level to keyboard level * Modernize keyboard's config.h file Aligns the keyboard-level config.h file more closely with the current QMK template for AVR keyboards.
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
* Delete null key `__` key in keymap.c doesn't actually exist on the physical hardware. Removed key from keymap.c and removed its argument from the layout macro. * Delete unused keycode aliases * Replace layer index definitions with an enum * Replace redundant numpad keycodes with native aliases * Use native layer change keycodes instead of aliases * Visually align the keycodes It makes the keymap pretty. * Correct Configurator layout data * Clean up header files - convert to pragma once include guard - remove redundant definitions - remove commented code blocks * Delete LAYOUT_kc macro Was copied from ergotravel; not valid for this keyboard. * Consolidate rev1 rules.mk settings to keyboard level Previous codebase enabled Backlight at keyboard level then disabled it at revision level. * Delete unused rules * Consolidate config.h settings from keymap level to keyboard level * Modernize keyboard's config.h file Aligns the keyboard-level config.h file more closely with the current QMK template for AVR keyboards.
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
* Delete null key `__` key in keymap.c doesn't actually exist on the physical hardware. Removed key from keymap.c and removed its argument from the layout macro. * Delete unused keycode aliases * Replace layer index definitions with an enum * Replace redundant numpad keycodes with native aliases * Use native layer change keycodes instead of aliases * Visually align the keycodes It makes the keymap pretty. * Correct Configurator layout data * Clean up header files - convert to pragma once include guard - remove redundant definitions - remove commented code blocks * Delete LAYOUT_kc macro Was copied from ergotravel; not valid for this keyboard. * Consolidate rev1 rules.mk settings to keyboard level Previous codebase enabled Backlight at keyboard level then disabled it at revision level. * Delete unused rules * Consolidate config.h settings from keymap level to keyboard level * Modernize keyboard's config.h file Aligns the keyboard-level config.h file more closely with the current QMK template for AVR keyboards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed some weirdness while making a QMK Configurator default keymap. Investigated and found some issues with the existing codebase.
Changes were checked by compiling the default keymap from branch base and then again from the development branch and comparing the SHA-256 hashes (which are the same).
External Reference
Types of Changes
Checklist