Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dfu-util and caterina udev examples #6429

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 28, 2019

Description

Currently the suggestion for caterina flashing is to disable ModemManager, however Udev can be told to filter out these devices. The only potential stumbling block is that filtering only works when not in strict mode, so I have added a note about this with a scripted workaround.
While in the area, I have also added some dfu-util Udev rules to cover the scenarios that I currently have access to.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team July 28, 2019 22:25
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@drashna drashna requested a review from a team July 30, 2019 05:40
@drashna
Copy link
Member

drashna commented Jul 30, 2019

@noroadsleft @mechmerlin any issues?

@noroadsleft
Copy link
Member

noroadsleft commented Jul 30, 2019

I'd like to review this tomorrow or Wednesday if I get the chance.

I recently had some trouble flashing some fresh Pro Micros. I attempted to flash them from my Linux Mint netbook, and adding the udev rules didn't get me anywhere – I had to resort to using sudo. I did however forget to check on ModemManager.

If @mechmerlin's okay with these changes, don't wait for me.

Copy link
Contributor

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only real comment, linux best practice is usually to put devices that need special access into a group like uucp and then add the user to that group. I think for most single user workstations this will be fine, but it might raise some hackles for hardcore linux sysadmins. Otherwise, approved. Tested udevadm changes on arch linux.

@drashna drashna merged commit b567785 into qmk:master Aug 1, 2019
raymond-w-ko pushed a commit to raymond-w-ko/qmk_firmware that referenced this pull request Aug 4, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Aug 6, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (240 commits)
  Move maartenwut's keyboards to one folder (qmk#6484)
  GH60 Refactor: Move Satan into GH60 directory (qmk#6485)
  Remove unused _BOOTLOADER defines
  [Keyboard] add keyboard-discipline (qmk#6464)
  [Split] Add config option for DIRECT_PINS_RIGHT (qmk#6479)
  [Keymap] Add some more commonly used symbols to melody96/zunger. (qmk#6478)
  [Keyboard] WT75-A & WT75-B fixes for QMK Configurator (qmk#6472)
  [Keymap] update to dsanchezseco keymap (qmk#6470)
  [Keymap] Fixed Tanuki RGB lighting (qmk#6462)
  Add iS0 Keypad (qmk#6456)
  [Keymap] jotix ortho_4x12_layout (qmk#6458)
  [Keyboard] New Keyboard: KBDPad MKI (qmk#6452)
  [Keymap] Adds Keymap for Iris/blucky (qmk#6449)
  [Keymap] Fixing Sol Rev2 default keymap OLED rotation. (qmk#6448)
  [Keyboard] QWERTYYdox refactor (qmk#6446)
  [Keymap] Adds keymap for muzfuz/lunar (qmk#6432)
  [Docs] Add dfu-util and caterina udev examples (qmk#6429)
  updates to akb/raine in ready for production units (qmk#6457)
  Removed print call to resolve  qmk#6364 (qmk#6413)
  Fix typo for building Ergodox EZ keyboards (qmk#6453)
  ...
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@zvecr zvecr deleted the feature/udev_rules branch April 28, 2020 00:40
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants