Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boston meetup 2019 #5611

Merged
merged 8 commits into from
Apr 23, 2019
Merged

Boston meetup 2019 #5611

merged 8 commits into from
Apr 23, 2019

Conversation

ishtob
Copy link
Contributor

@ishtob ishtob commented Apr 12, 2019 •
edited
Loading

Adding Boston MK meetup macropad,

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mechmerlin
mechmerlin requested changes Apr 12, 2019
View reviewed changes
keyboards/boston_meetup/readme.md Outdated Show resolved Hide resolved
keyboards/boston_meetup/2019/mcuconf.h Outdated Show resolved Hide resolved
keyboards/boston_meetup/2019/mcuconf.h Outdated Show resolved Hide resolved
keyboards/boston_meetup/2019/mcuconf.h Outdated Show resolved Hide resolved
keyboards/boston_meetup/2019/keymaps/readme.md Outdated Show resolved Hide resolved
keyboards/boston_meetup/2019/halconf.h Outdated Show resolved Hide resolved
keyboards/boston_meetup/2019/halconf.h Outdated Show resolved Hide resolved
keyboards/boston_meetup/2019/halconf.h Outdated Show resolved Hide resolved
keyboards/boston_meetup/2019/2019.c Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Apr 12, 2019
View reviewed changes
keyboards/boston_meetup/2019/info.json Outdated Show resolved Hide resolved
keyboards/boston_meetup/2019/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/boston_meetup/2019/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/boston_meetup/2019/keymaps/default/readme.md Outdated Show resolved Hide resolved
keyboards/boston_meetup/readme.md Outdated Show resolved Hide resolved
keyboards/boston_meetup/readme.md Outdated Show resolved Hide resolved
keyboards/boston_meetup/config.h Outdated Show resolved Hide resolved
keyboards/boston_meetup/readme.md Outdated Show resolved Hide resolved
@noroadsleft @ishtob
Spelling fix
f8ee89e 
Co-Authored-By: ishtob <ishtob@gmail.com>
drashna
drashna reviewed Apr 16, 2019
View reviewed changes
keyboards/boston_meetup/2019/2019.c

uint32_t layer_state_set_kb(uint32_t state) {
state = layer_state_set_user(state);
layer = biton32(state);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like it's used?

Also, not sure you need this, since layer_state is a global variable that you can pull from anywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its so if there is a change in layer (timed event or what not) the OLED would receive the change state and send for a new refersh to the display

mechmerlin
mechmerlin approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mechmerlin mechmerlin merged commit ce8fb1e into qmk:master Apr 23, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Apr 26, 2019
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
bc5db1c 
* 'master' of https://github.com/qmk/qmk_firmware: (99 commits)
  [Keyboard] Add a new keyboard ADKB96 (qmk#5685)
  test commit
  add RGBLIGHT_SPLIT_SET_CHANGE_MODEHSVS; to rgblight_update_dword()
  add RGBLIGHT_SPLIT_SET_CHANGE_MODEHSVS; to eeconfig_update_rgblight_default()
  Refactor cospad to current standards and enable support for backlight keycodes (qmk#5582)
  [Keymap] update (mouse emulation, rev 6 compatibility) (qmk#5696)
  [Keyboard] fix project zen rev1 bootloader declaration (qmk#5695)
  [FIX] Misspelled RGB_YELLOW (qmk#5692)
  [Keymap] Fix broken Shift-Insert binding (qmk#5689)
  [Keyboard] forgot to omit k05 from the electrical matrix in hhkb layout (qmk#5684)
  [Keyboard] Fix red an green leds location (qmk#5698)
  Translate docs into Chinese (qmk#5693)
  [Keymap] Fix my userspace RGB bug (qmk#5686)
  Boston meetup 2019 (qmk#5611)
  [Keymap] Update to Drashna Keymaps (qmk#5594)
  fix LIB_SRC and QUANTUM_LIB_SRC for ARM (qmk#5623)
  RGB Matrix Animations: Three/six new reactive effects (wide, cross, nexus) (qmk#5602)
  Fix qmk#3566 use an hardware timer for software PWM stability (qmk#3615)
  added info.json for ymd96 (qmk#4982)
  Define RGB colors (qmk#5300)
  ...
KauyonKais pushed a commit to KauyonKais/qmk_firmware that referenced this pull request Apr 27, 2019
@ishtob @KauyonKais
Boston meetup 2019 (qmk#5611)
cc3319b 
* Add boston_meetup folder for community meetup macropads

* Modify OLED indicators to match macropad

* PR cleanup

* Spelling fix

Co-Authored-By: ishtob <ishtob@gmail.com>

* convert custom matrix to standard matrix defines

* refactor layer define with enum

* Remove un-used files

* remove "\" in keymap
foosinn pushed a commit to foosinn/qmk_firmware that referenced this pull request May 6, 2019
@ishtob @foosinn
Boston meetup 2019 (qmk#5611)
b65ca9c 
* Add boston_meetup folder for community meetup macropads

* Modify OLED indicators to match macropad

* PR cleanup

* Spelling fix

Co-Authored-By: ishtob <ishtob@gmail.com>

* convert custom matrix to standard matrix defines

* refactor layer define with enum

* Remove un-used files

* remove "\" in keymap
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@ishtob @Timbus
Boston meetup 2019 (qmk#5611)
211a2e5 
* Add boston_meetup folder for community meetup macropads

* Modify OLED indicators to match macropad

* PR cleanup

* Spelling fix

Co-Authored-By: ishtob <ishtob@gmail.com>

* convert custom matrix to standard matrix defines

* refactor layer define with enum

* Remove un-used files

* remove "\" in keymap
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@ishtob @JeffreyPalmer
Boston meetup 2019 (qmk#5611)
aca41aa 
* Add boston_meetup folder for community meetup macropads

* Modify OLED indicators to match macropad

* PR cleanup

* Spelling fix

Co-Authored-By: ishtob <ishtob@gmail.com>

* convert custom matrix to standard matrix defines

* refactor layer define with enum

* Remove un-used files

* remove "\" in keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft requested changes

@fauxpark fauxpark fauxpark left review comments

@mechmerlin mechmerlin mechmerlin approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ishtob @drashna @fauxpark @noroadsleft @mechmerlin