Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgot to omit k05 from the electrical matrix in hhkb layout #5684

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Forgot to omit k05 from the electrical matrix in hhkb layout #5684

merged 1 commit into from
Apr 24, 2019

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Apr 22, 2019 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin mechmerlin added the bug label Apr 22, 2019
@mechmerlin mechmerlin changed the title forgot to omit k05 from the electrical matrix in hhkb layout [WIP] forgot to omit k05 from the electrical matrix in hhkb layout Apr 22, 2019
@mechmerlin mechmerlin changed the title [WIP] forgot to omit k05 from the electrical matrix in hhkb layout Forgot to omit k05 from the electrical matrix in hhkb layout Apr 23, 2019
@drashna
Copy link
Member

drashna commented Apr 24, 2019

Thanks!

@drashna drashna merged commit 703699b into qmk:master Apr 24, 2019
@mechmerlin mechmerlin deleted the feature/e6v2_compile branch April 24, 2019 13:42
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Apr 26, 2019
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
bc5db1c 
* 'master' of https://github.com/qmk/qmk_firmware: (99 commits)
  [Keyboard] Add a new keyboard ADKB96 (qmk#5685)
  test commit
  add RGBLIGHT_SPLIT_SET_CHANGE_MODEHSVS; to rgblight_update_dword()
  add RGBLIGHT_SPLIT_SET_CHANGE_MODEHSVS; to eeconfig_update_rgblight_default()
  Refactor cospad to current standards and enable support for backlight keycodes (qmk#5582)
  [Keymap] update (mouse emulation, rev 6 compatibility) (qmk#5696)
  [Keyboard] fix project zen rev1 bootloader declaration (qmk#5695)
  [FIX] Misspelled RGB_YELLOW (qmk#5692)
  [Keymap] Fix broken Shift-Insert binding (qmk#5689)
  [Keyboard] forgot to omit k05 from the electrical matrix in hhkb layout (qmk#5684)
  [Keyboard] Fix red an green leds location (qmk#5698)
  Translate docs into Chinese (qmk#5693)
  [Keymap] Fix my userspace RGB bug (qmk#5686)
  Boston meetup 2019 (qmk#5611)
  [Keymap] Update to Drashna Keymaps (qmk#5594)
  fix LIB_SRC and QUANTUM_LIB_SRC for ARM (qmk#5623)
  RGB Matrix Animations: Three/six new reactive effects (wide, cross, nexus) (qmk#5602)
  Fix qmk#3566 use an hardware timer for software PWM stability (qmk#3615)
  added info.json for ymd96 (qmk#4982)
  Define RGB colors (qmk#5300)
  ...
foosinn pushed a commit to foosinn/qmk_firmware that referenced this pull request May 6, 2019
@mechmerlin @foosinn
[Keyboard] forgot to omit k05 from the electrical matrix in hhkb layo…
2f7fd6d 
…ut (qmk#5684)
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@mechmerlin @Timbus
[Keyboard] forgot to omit k05 from the electrical matrix in hhkb layo…
413a9bf 
…ut (qmk#5684)
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@mechmerlin @JeffreyPalmer
[Keyboard] forgot to omit k05 from the electrical matrix in hhkb layo…
a1e36b9 
…ut (qmk#5684)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mechmerlin @drashna