Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update features to use Custom Tapping Term when appropriate #6259

Merged
merged 12 commits into from
Jul 25, 2020
Merged

Update features to use Custom Tapping Term when appropriate #6259

merged 12 commits into from
Jul 25, 2020

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 5, 2019 •
edited
Loading

This updates both the Space Cadet feature, and Tap Dances to use the Custom Tapping Term functionality, so that you can check them as well.

For the Tap Dance feature, this completely removes the need for the ACTION_TAP_DANCE_FN_ADVANCED_TIME dance, but I didn't want to remove it, as a few keymaps do rely on this function.

Types of Changes

  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna changed the title Update Space Cadet to use Custom Tapping Term functionality Update features to use Custom Tapping Term when appropriate Jul 7, 2019
@drashna
Copy link
Member Author

drashna commented Jul 7, 2019

@nikchi @salchipapa and @epaew, would you be willing to test out these changes, as your keymaps use the ACTION_TAP_DANCE_FN_ADVANCED_TIME feature?

@drashna drashna mentioned this pull request Jul 11, 2019
Merged
13 tasks
@drashna drashna requested review from zvecr and removed request for fredizzimo July 16, 2019 08:44
@drashna drashna requested a review from a team August 21, 2019 05:56
@drashna drashna force-pushed the fix/use_custom_tapping_term_for_space_cadet branch from c152f60 to e710695 Compare August 30, 2019 23:55
@drashna drashna force-pushed the fix/use_custom_tapping_term_for_space_cadet branch from e710695 to 79b109b Compare October 31, 2019 00:15
@drashna drashna force-pushed the fix/use_custom_tapping_term_for_space_cadet branch 2 times, most recently from f6f940e to 1e6ec7a Compare November 16, 2019 17:15
@stale
Copy link

stale bot commented Dec 31, 2019

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Jan 2, 2020
zvecr
zvecr reviewed Jan 28, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perform_space_cadet is used at the keyboard level, with its signature changed ive marked this as a breaking change.

@zvecr zvecr added the breaking_change Changes that need to wait for a version increment label Jan 28, 2020
fauxpark
fauxpark requested changes Jan 28, 2020
View reviewed changes
quantum/process_keycode/process_space_cadet.c Outdated Show resolved Hide resolved
quantum/process_keycode/process_space_cadet.c Outdated Show resolved Hide resolved
quantum/process_keycode/process_space_cadet.h Outdated Show resolved Hide resolved
@drashna drashna force-pushed the fix/use_custom_tapping_term_for_space_cadet branch 2 times, most recently from 83d3f0a to 701190d Compare March 9, 2020 19:11
@drashna drashna mentioned this pull request Mar 31, 2020
Closed
13 tasks
@drashna
Copy link
Member Author

drashna commented Mar 31, 2020

Just reviewing this PR...

perform_space_cadet is used at the keyboard level, with its signature changed i've marked this as a breaking change.

Not sure what you mean here.
I do see one user that uses it in their keymap, yes (@narze's keymaps). But elsewhere, it's only used in perform_space_cadet function.

That said, I can separate these changes into a tap dance and space cadet PR, if that helps.

@fauxpark fauxpark mentioned this pull request Jul 24, 2020
Closed
13 tasks
@tzarc
Copy link
Member

tzarc commented Jul 25, 2020

@drashna anything else pending or can we get this merged?

@drashna
Copy link
Member Author

drashna commented Jul 25, 2020

Should be good to go.

@tzarc tzarc merged commit 83ba7bc into qmk:develop Jul 25, 2020
@tzarc
Copy link
Member

tzarc commented Jul 25, 2020

Done.

noroadsleft added a commit that referenced this pull request Jul 26, 2020
@drashna @fauxpark @noroadsleft
Update features to use Custom Tapping Term when appropriate (#6259)
58c8a6d 
* Update Space Cadet to use Custom Tapping Term functionality

* Detect correct keycode for space cadet tapping term

* Update tap dancing to use global custom tapping term

* Update documentation for Tap Dances

* formatting pass

* Apply suggestions from code review

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update docs/feature_tap_dance.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update for future

* Update user keymaps for space cadet

* Fix typos

* Clean up tapping term stuff

* Fix compiler issue if NO_ACTION_TAPPING is enabled

Co-authored-by: fauxpark <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@drashna drashna deleted the fix/use_custom_tapping_term_for_space_cadet branch July 27, 2020 03:47
@drashna drashna mentioned this pull request Jul 31, 2020
Closed
3 tasks
noroadsleft added a commit that referenced this pull request Jul 31, 2020
@drashna @fauxpark @noroadsleft
Update features to use Custom Tapping Term when appropriate (#6259)
93c8bd4 
* Update Space Cadet to use Custom Tapping Term functionality

* Detect correct keycode for space cadet tapping term

* Update tap dancing to use global custom tapping term

* Update documentation for Tap Dances

* formatting pass

* Apply suggestions from code review

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update docs/feature_tap_dance.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update for future

* Update user keymaps for space cadet

* Fix typos

* Clean up tapping term stuff

* Fix compiler issue if NO_ACTION_TAPPING is enabled

Co-authored-by: fauxpark <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
noroadsleft added a commit that referenced this pull request Aug 11, 2020
@drashna @fauxpark @noroadsleft
Update features to use Custom Tapping Term when appropriate (#6259)
fca5b6f 
* Update Space Cadet to use Custom Tapping Term functionality

* Detect correct keycode for space cadet tapping term

* Update tap dancing to use global custom tapping term

* Update documentation for Tap Dances

* formatting pass

* Apply suggestions from code review

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update docs/feature_tap_dance.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update for future

* Update user keymaps for space cadet

* Fix typos

* Clean up tapping term stuff

* Fix compiler issue if NO_ACTION_TAPPING is enabled

Co-authored-by: fauxpark <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
noroadsleft added a commit that referenced this pull request Aug 27, 2020
@drashna @fauxpark @noroadsleft
Update features to use Custom Tapping Term when appropriate (#6259)
42dea38 
* Update Space Cadet to use Custom Tapping Term functionality

* Detect correct keycode for space cadet tapping term

* Update tap dancing to use global custom tapping term

* Update documentation for Tap Dances

* formatting pass

* Apply suggestions from code review

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update docs/feature_tap_dance.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update for future

* Update user keymaps for space cadet

* Fix typos

* Clean up tapping term stuff

* Fix compiler issue if NO_ACTION_TAPPING is enabled

Co-authored-by: fauxpark <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
noroadsleft added a commit that referenced this pull request Aug 29, 2020
@drashna @fauxpark @noroadsleft
Update features to use Custom Tapping Term when appropriate (#6259)
9d3b26a 
* Update Space Cadet to use Custom Tapping Term functionality

* Detect correct keycode for space cadet tapping term

* Update tap dancing to use global custom tapping term

* Update documentation for Tap Dances

* formatting pass

* Apply suggestions from code review

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update docs/feature_tap_dance.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update for future

* Update user keymaps for space cadet

* Fix typos

* Clean up tapping term stuff

* Fix compiler issue if NO_ACTION_TAPPING is enabled

Co-authored-by: fauxpark <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@drashna @fauxpark
@noroadsleft @nicocesar
Update features to use Custom Tapping Term when appropriate (qmk#6259)
6da3617 
* Update Space Cadet to use Custom Tapping Term functionality

* Detect correct keycode for space cadet tapping term

* Update tap dancing to use global custom tapping term

* Update documentation for Tap Dances

* formatting pass

* Apply suggestions from code review

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update docs/feature_tap_dance.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update for future

* Update user keymaps for space cadet

* Fix typos

* Clean up tapping term stuff

* Fix compiler issue if NO_ACTION_TAPPING is enabled

Co-authored-by: fauxpark <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
drashna added a commit to zsa/qmk_firmware that referenced this pull request Sep 30, 2020
@drashna @fauxpark @noroadsleft
Update features to use Custom Tapping Term when appropriate (qmk#6259)
7d63eef 
* Update Space Cadet to use Custom Tapping Term functionality

* Detect correct keycode for space cadet tapping term

* Update tap dancing to use global custom tapping term

* Update documentation for Tap Dances

* formatting pass

* Apply suggestions from code review

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update docs/feature_tap_dance.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update for future

* Update user keymaps for space cadet

* Fix typos

* Clean up tapping term stuff

* Fix compiler issue if NO_ACTION_TAPPING is enabled

Co-authored-by: fauxpark <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@drashna @fauxpark @noroadsleft
Update features to use Custom Tapping Term when appropriate (qmk#6259)
a2f3ae8 
* Update Space Cadet to use Custom Tapping Term functionality

* Detect correct keycode for space cadet tapping term

* Update tap dancing to use global custom tapping term

* Update documentation for Tap Dances

* formatting pass

* Apply suggestions from code review

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update docs/feature_tap_dance.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update for future

* Update user keymaps for space cadet

* Fix typos

* Clean up tapping term stuff

* Fix compiler issue if NO_ACTION_TAPPING is enabled

Co-authored-by: fauxpark <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@sigprof sigprof mentioned this pull request Feb 27, 2022
Merged
14 tasks
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna @fauxpark @noroadsleft
Update features to use Custom Tapping Term when appropriate (qmk#6259)
0c566f1 
* Update Space Cadet to use Custom Tapping Term functionality

* Detect correct keycode for space cadet tapping term

* Update tap dancing to use global custom tapping term

* Update documentation for Tap Dances

* formatting pass

* Apply suggestions from code review

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update docs/feature_tap_dance.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update for future

* Update user keymaps for space cadet

* Fix typos

* Clean up tapping term stuff

* Fix compiler issue if NO_ACTION_TAPPING is enabled

Co-authored-by: fauxpark <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

@mechmerlin mechmerlin Awaiting requested review from mechmerlin

@skullydazed skullydazed Awaiting requested review from skullydazed

@yanfali yanfali Awaiting requested review from yanfali

Assignees
No one assigned
Labels
awaiting review breaking_change Changes that need to wait for a version increment enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drashna @fauxpark @tzarc @zvecr @noroadsleft