Make tap dance prefer tapping term from get_tapping_term over TAPPING_TERM #9806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the CI build failed, it looks like some JavaScript error? |
|
Duplicate of #6259 |
|
I agree with this change! but as fauxpark has pointed out, it's already been fixed on But thank you for the submission! I'm going to go ahead and close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the
get_tapping_termmethod to your keymap.c allows you to control the tapping term from your code, and specify what it will be based on the keycode. Previously tap dance would not use this; it would only use the parameter passed to it (if you usedACTION_TAP_DANCE_FN_ADVANCED_TIME) or the definedTAPPING_TERM. This PR makes it use the result ofget_tapping_termifTAPPING_TERM_PER_KEYis defined.Types of Changes
Issues Fixed or Closed by This PR
Checklist