Turn off RGB Matrix LEDs when keyboard sleeps #7713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XScorpion2
approved these changes
Dec 25, 2019
|
Also would be nice to get this pr in as well: #6480 |
zvecr
approved these changes
Dec 25, 2019
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Dec 26, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (226 commits) Make the keyboard beep when Audio is enabled and `\a` is encountered in a sendstring Turn off RGB Matrix LEDs when keyboard sleeps (qmk#7713) Add backwards compatibility for oled_write_raw_P on ARM Update toshi0383 keymap (qmk#7700) Completely remove i2c_transmit_receive function (qmk#7686) Readded lost pgm_read_word code to encoder array lookups (qmk#7577) Add central location for ChibiOS defines (qmk#7542) Add TADA68 keymap/rules/config for QMK bootloader (qmk#7679) [Docs] fix docs (qmk#7642) [Keyboard] Clueboard 60 fix col 11 12 mixup (qmk#7685) Missed these LTO blocks I corrected my name. [Keymap] Added userspace for d4mation. Included their keymap for the Atreus62 (qmk#7483) [Keymap] Custom user keymap for Think6.5 with LED range control (qmk#7603) [Keymap] CRKBD Custom Keymap - KidBrazil (qmk#7630) [Keymap] Add pico 70 keys keymap (qmk#7654) Improve docs "Edit Document" footer Tidy up dztech config.h Tidy up dztech default keymaps and info.json (qmk#7608) Heisenberg handwired keyboard added (qmk#7643) ...
patrl
pushed a commit
to patrl/qmk_firmware
that referenced
this pull request
Dec 29, 2019
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when suspend/sleep is enabled for the rgb matrix, it sets a boolean toggle, which prevents the animation from being updated. This was fine when the entire animation was done each cycle, but because the animation is sliced up (and has been for a while), it can lead to a state where some of the LEDs are on, but the rest are not, as it's mid animation.
This forcibly turns off (well, sets to black/blank) all of the LEDs when the keyboard goes to sleep (and only then), so that all the lights are off.
Types of Changes
Checklist