Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added userspace for d4mation. Included their keymap for the Atreus62 #7483

Merged
merged 7 commits into from
Dec 18, 2019
Merged

Added userspace for d4mation. Included their keymap for the Atreus62 #7483

merged 7 commits into from
Dec 18, 2019

Conversation

d4mation
Copy link
Contributor

@d4mation d4mation commented Nov 26, 2019 •
edited
Loading

Adds the d4mation userspace, as well as my keymap for the Atreus62 keyboard

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna reviewed Nov 26, 2019
View reviewed changes
users/d4mation/macros.c Outdated Show resolved Hide resolved
drashna
drashna reviewed Nov 27, 2019
View reviewed changes
users/d4mation/config.h Outdated Show resolved Hide resolved
drashna
drashna reviewed Nov 27, 2019
View reviewed changes
users/d4mation/config.h Outdated Show resolved Hide resolved
drashna
drashna reviewed Nov 27, 2019
View reviewed changes
users/d4mation/rules.mk Outdated Show resolved Hide resolved
users/d4mation/config.h Outdated Show resolved Hide resolved
@d4mation
Copy link
Contributor Author

@drashna thank you for all the feedback! I won't be able to address any of these until after the holiday weekend, but I'm looking forward to digging into these.

PS: your past comments in /r/qmk were really helpful to me in getting as far as I did with my user space and keymap :)

@drashna
Copy link
Member

drashna commented Dec 4, 2019

You're very welcome, and no worries! It's a busy time of year, so we absolutely understand how it goes.

And you're very welcome!

@d4mation
Copy link
Contributor Author

@drashna

Had a chance to look into all this and I believe I have made the changes you requested correctly. If anything seems off, let me know!

drashna
drashna approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

And thanks!!

@drashna drashna merged commit f42dd61 into qmk:master Dec 18, 2019
benjaminmikiten added a commit to benjaminmikiten/qmk_firmware that referenced this pull request Dec 18, 2019
@benjaminmikiten
Merge branch 'master' into develop
db79a5b 
* master: (99 commits)
  [Keymap] Added userspace for d4mation. Included their keymap for the Atreus62 (qmk#7483)
  [Keymap] Custom user keymap for Think6.5 with LED range control (qmk#7603)
  [Keymap] CRKBD Custom Keymap - KidBrazil (qmk#7630)
  [Keymap] Add pico 70 keys keymap (qmk#7654)
  Tidy up dztech default keymaps and info.json (qmk#7608)
  Heisenberg handwired keyboard added (qmk#7643)
  [Keyboard] Added Filco Majestouch TKL Pegasus Hoof ISO Layout (qmk#7647)
  Ported J80 to QMK (qmk#7488)
  [Keyboard] Magnavox Videowriter conversion with Pro Micro (qmk#7634)
  [Docs] add japanese translation (basic part) (qmk#7461)
  Tidy up dztech rules.mk
  Relocate RGB keycode processing (qmk#7508)
  Move kwerdenker's personal keymap from RGB (qmk#7645)
  Remove QMK_KEYBOARD_CONFIG_H from boards (qmk#7635)
  Disable usb on slave half to resolve random 'lockup' (qmk#7649)
  [Core] Optimize matrix processing (qmk#7621)
  [Keymap] boy_314's satisfaction75 layout (qmk#7638)
  [Keyboard] XD68 65% ATMega32U4 based (qmk#7395)
  [keyboard] Plain60 cleanups (qmk#7644)
  update default h88 keymap (qmk#7646)
  ...
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Dec 26, 2019
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
01b7405 
* 'master' of https://github.com/qmk/qmk_firmware: (226 commits)
  Make the keyboard beep when Audio is enabled and `\a` is encountered in a sendstring
  Turn off RGB Matrix LEDs when keyboard sleeps (qmk#7713)
  Add backwards compatibility for oled_write_raw_P on ARM
  Update toshi0383 keymap (qmk#7700)
  Completely remove i2c_transmit_receive function (qmk#7686)
  Readded lost pgm_read_word code to encoder array lookups (qmk#7577)
  Add central location for ChibiOS defines (qmk#7542)
  Add TADA68 keymap/rules/config for QMK bootloader (qmk#7679)
  [Docs] fix docs (qmk#7642)
  [Keyboard] Clueboard 60 fix col 11 12 mixup (qmk#7685)
  Missed these LTO blocks
  I corrected my name.
  [Keymap] Added userspace for d4mation. Included their keymap for the Atreus62 (qmk#7483)
  [Keymap] Custom user keymap for Think6.5 with LED range control (qmk#7603)
  [Keymap] CRKBD Custom Keymap - KidBrazil (qmk#7630)
  [Keymap] Add pico 70 keys keymap (qmk#7654)
  Improve docs "Edit Document" footer
  Tidy up dztech config.h
  Tidy up dztech default keymaps and info.json (qmk#7608)
  Heisenberg handwired keyboard added (qmk#7643)
  ...
akrob pushed a commit to akrob/qmk_firmware that referenced this pull request Dec 28, 2019
Merge remote-tracking branch 'upstream/master'
6edd8aa 
* upstream/master: (1080 commits)
  Update toshi0383 keymap (qmk#7700)
  Completely remove i2c_transmit_receive function (qmk#7686)
  Readded lost pgm_read_word code to encoder array lookups (qmk#7577)
  Add central location for ChibiOS defines (qmk#7542)
  Add TADA68 keymap/rules/config for QMK bootloader (qmk#7679)
  [Docs] fix docs (qmk#7642)
  [Keyboard] Clueboard 60 fix col 11 12 mixup (qmk#7685)
  Missed these LTO blocks
  I corrected my name.
  [Keymap] Added userspace for d4mation. Included their keymap for the Atreus62 (qmk#7483)
  [Keymap] Custom user keymap for Think6.5 with LED range control (qmk#7603)
  [Keymap] CRKBD Custom Keymap - KidBrazil (qmk#7630)
  [Keymap] Add pico 70 keys keymap (qmk#7654)
  Improve docs "Edit Document" footer
  Tidy up dztech config.h
  Tidy up dztech default keymaps and info.json (qmk#7608)
  Heisenberg handwired keyboard added (qmk#7643)
  [Keyboard] Added Filco Majestouch TKL Pegasus Hoof ISO Layout (qmk#7647)
  Ported J80 to QMK (qmk#7488)
  [Keyboard] Magnavox Videowriter conversion with Pro Micro (qmk#7634)
  ...
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@d4mation @patrl
[Keymap] Added userspace for d4mation. Included their keymap for the …
7fcd0f1 
…Atreus62 (qmk#7483)

* Added userspace for d4mation. Included their keymap for the Atreus62

* Do not assign layer numbers manually

* Remove some unneeded things per @drashna's recommendation

* Fix some single line comments I missed

* Update unicode macros to use send_unicode_hex_string() instead of process_unicode()

* OBetter check for Unicode Enabled. Moved some checks into macros.c

* Use eeconfig_init_user() to set default unicode input mode
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@d4mation @HokieGeek
[Keymap] Added userspace for d4mation. Included their keymap for the …
633ce31 
…Atreus62 (qmk#7483)

* Added userspace for d4mation. Included their keymap for the Atreus62

* Do not assign layer numbers manually

* Remove some unneeded things per @drashna's recommendation

* Fix some single line comments I missed

* Update unicode macros to use send_unicode_hex_string() instead of process_unicode()

* OBetter check for Unicode Enabled. Moved some checks into macros.c

* Use eeconfig_init_user() to set default unicode input mode
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@d4mation @kujawakk
[Keymap] Added userspace for d4mation. Included their keymap for the …
6ec5b53 
…Atreus62 (qmk#7483)

* Added userspace for d4mation. Included their keymap for the Atreus62

* Do not assign layer numbers manually

* Remove some unneeded things per @drashna's recommendation

* Fix some single line comments I missed

* Update unicode macros to use send_unicode_hex_string() instead of process_unicode()

* OBetter check for Unicode Enabled. Moved some checks into macros.c

* Use eeconfig_init_user() to set default unicode input mode
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@d4mation @drashna
[Keymap] Added userspace for d4mation. Included their keymap for the …
82e509f 
…Atreus62 (qmk#7483)

* Added userspace for d4mation. Included their keymap for the Atreus62

* Do not assign layer numbers manually

* Remove some unneeded things per @drashna's recommendation

* Fix some single line comments I missed

* Update unicode macros to use send_unicode_hex_string() instead of process_unicode()

* OBetter check for Unicode Enabled. Moved some checks into macros.c

* Use eeconfig_init_user() to set default unicode input mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d4mation @drashna @fauxpark