Move kwerdenker's personal keymap from RGB #7645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 15, 2019 08:39
Talked to Maartenwut about making RGB an actual template instead of kwerdenker's keymap. Free'd up B7 so it can be used for audio in agreement with MW. He's considering adding a speaker footprint to next rev of plain60, and only B7 can be used with Audio. RGB uses bitbang driver so it doesn't really make any difference if it's pin B0. - RGB should be a template for other people to modify, not a personal keymap - change default pin to B0 to free up B7 for audio use - rename RGB to kwerdenker
- doesn't work properly on MacOS or Windows
- maintain compatibility with old keymap
drashna
approved these changes
Dec 16, 2019
nooges
approved these changes
Dec 16, 2019
|
Don't have a problem with it. Thought nobody beside myself did any mods to the PCB, so saw no need to generalize the keymap. Thank you for the work @yanfali |
benjaminmikiten
added a commit
to benjaminmikiten/qmk_firmware
that referenced
this pull request
Dec 18, 2019
* master: (99 commits) [Keymap] Added userspace for d4mation. Included their keymap for the Atreus62 (qmk#7483) [Keymap] Custom user keymap for Think6.5 with LED range control (qmk#7603) [Keymap] CRKBD Custom Keymap - KidBrazil (qmk#7630) [Keymap] Add pico 70 keys keymap (qmk#7654) Tidy up dztech default keymaps and info.json (qmk#7608) Heisenberg handwired keyboard added (qmk#7643) [Keyboard] Added Filco Majestouch TKL Pegasus Hoof ISO Layout (qmk#7647) Ported J80 to QMK (qmk#7488) [Keyboard] Magnavox Videowriter conversion with Pro Micro (qmk#7634) [Docs] add japanese translation (basic part) (qmk#7461) Tidy up dztech rules.mk Relocate RGB keycode processing (qmk#7508) Move kwerdenker's personal keymap from RGB (qmk#7645) Remove QMK_KEYBOARD_CONFIG_H from boards (qmk#7635) Disable usb on slave half to resolve random 'lockup' (qmk#7649) [Core] Optimize matrix processing (qmk#7621) [Keymap] boy_314's satisfaction75 layout (qmk#7638) [Keyboard] XD68 65% ATMega32U4 based (qmk#7395) [keyboard] Plain60 cleanups (qmk#7644) update default h88 keymap (qmk#7646) ...
patrl
pushed a commit
to patrl/qmk_firmware
that referenced
this pull request
Dec 29, 2019
* Move kwerdenker's personal keymap from RGB Talked to Maartenwut about making RGB an actual template instead of kwerdenker's keymap. Free'd up B7 so it can be used for audio in agreement with MW. He's considering adding a speaker footprint to next rev of plain60, and only B7 can be used with Audio. RGB uses bitbang driver so it doesn't really make any difference if it's pin B0. - RGB should be a template for other people to modify, not a personal keymap - change default pin to B0 to free up B7 for audio use - rename RGB to kwerdenker * Add RGB keycodes to FN layer * don't use uppercase in keymap names - doesn't work properly on MacOS or Windows * Add an audio specific keymap * Enum instead of define * Suggested change to keymap - maintain compatibility with old keymap
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
* Move kwerdenker's personal keymap from RGB Talked to Maartenwut about making RGB an actual template instead of kwerdenker's keymap. Free'd up B7 so it can be used for audio in agreement with MW. He's considering adding a speaker footprint to next rev of plain60, and only B7 can be used with Audio. RGB uses bitbang driver so it doesn't really make any difference if it's pin B0. - RGB should be a template for other people to modify, not a personal keymap - change default pin to B0 to free up B7 for audio use - rename RGB to kwerdenker * Add RGB keycodes to FN layer * don't use uppercase in keymap names - doesn't work properly on MacOS or Windows * Add an audio specific keymap * Enum instead of define * Suggested change to keymap - maintain compatibility with old keymap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Talked to Maartenwut about making RGB an actual template instead of
kwerdenker's keymap. Free'd up B7 so it can be used for audio in
agreement with MW. He's considering adding a speaker footprint to next
rev of plain60, and only B7 can be used with Audio. RGB uses bitbang
driver so it doesn't really make any difference if it's pin B0.
keymap
@kwerdenker you ok with this? Basically it's to add a new feature to plain60 pcb, and I noticed that the RGB keymap was not generic but highly specific. I've based new RGB keymap on default.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist