Use PSR HTTP factory interface #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ementation. JsonApiFactory had a concrete dependancy. To improve usability and respect Dependancy Inversion Principle we chose to use interface instead. It allows implementer to use the implementation he wants even if sensio/framework-extra-bundle combined with symfony/psr-http-message-bridge hardly suggest to use nyholm/psr7. That is why we think it is irrelevant to suggest an implementation because one of our requirements already dit that.
qpautrat
force-pushed
the
use-psr-http-factory-interface
branch
from
e68f656
to
328b36b
Compare
Doqnach
suggested changes
Dec 23, 2019
qpautrat
force-pushed
the
use-psr-http-factory-interface
branch
from
328b36b
to
95f7493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
JsonApiFactory had a concrete dependency to
nyholm/psr7.To improve usability and respect Dependency Inversion Principle we chose to use interface instead.
It allows implementer to use the implementation he wants even if
sensio/framework-extra-bundlecombined withsymfony/psr-http-message-bridgehardly suggest to usenyholm/psr7.That is why we think it is irrelevant to suggest an implementation because one of our requirements already dit that.
Fixes #20.
Backward Compatibility
Because we change the dependencies it means that the bundle could not work the same as before.
We need to bump to a new major version.