Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PSR HTTP factory interface #24

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Use PSR HTTP factory interface #24

merged 1 commit into from
Dec 23, 2019

Commits on Dec 23, 2019

  1. refactor: Rely on PSR HTTP factory interface instead of concrete impl… 

    …ementation.

JsonApiFactory had a concrete dependancy.
To improve usability and respect Dependancy Inversion Principle we chose to use interface instead.
It allows implementer to use the implementation he wants even if sensio/framework-extra-bundle combined
with symfony/psr-http-message-bridge hardly suggest to use nyholm/psr7.
That is why we think it is irrelevant to suggest an implementation because one of our requirements already dit that.
    @qpautrat
    qpautrat committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    95f7493 View commit details
    Browse the repository at this point in the history