Skip to content

Commit

Permalink
Fix test_notebooks_against_cirq_head for MacOS platform (#6366)
Browse files Browse the repository at this point in the history
* And enable that test in CI-daily on MacOS

Partially implements #6336
  • Loading branch information
smburdick authored Dec 2, 2023
1 parent 6ea5ae1 commit 30b6c39
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci-daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ jobs:
pip install \
-r dev_tools/requirements/deps/format.txt \
-r dev_tools/requirements/deps/pylint.txt \
-r dev_tools/requirements/deps/pytest.txt
-r dev_tools/requirements/deps/pytest.txt \
-r dev_tools/requirements/deps/notebook.txt
- name: Pytest check
run: check/pytest -n auto --ignore=cirq-core/cirq/contrib --enable-slow-tests
4 changes: 2 additions & 2 deletions dev_tools/notebooks/notebook_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@

import importlib.metadata
import os
import sys
import tempfile

import pytest

from dev_tools import shell_tools
from dev_tools.notebooks import filter_notebooks, list_all_notebooks, rewrite_notebook
from dev_tools.test_utils import only_on_posix

SKIP_NOTEBOOKS = [
# skipping vendor notebooks as we don't have auth sorted out
Expand Down Expand Up @@ -87,7 +87,7 @@ def env_with_temporary_pip_target():


@pytest.mark.slow
@pytest.mark.skipif(sys.platform != "linux", reason="Linux-only test")
@only_on_posix
@pytest.mark.parametrize("notebook_path", filter_notebooks(list_all_notebooks(), SKIP_NOTEBOOKS))
def test_notebooks_against_cirq_head(
notebook_path, require_packages_not_changed, env_with_temporary_pip_target
Expand Down
1 change: 1 addition & 0 deletions dev_tools/requirements/deps/notebook.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ ipykernel==5.3.4

# for executing notebooks in tests
papermill~=2.3.2
quimb~=1.6.0

# assumed to be part of colab
seaborn~=0.11.1

0 comments on commit 30b6c39

Please sign in to comment.