-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI MacOS to fix notebook test error #6366
Update CI MacOS to fix notebook test error #6366
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6366 +/- ##
==========================================
- Coverage 97.80% 97.80% -0.01%
==========================================
Files 1111 1111
Lines 96878 96878
==========================================
- Hits 94756 94755 -1
- Misses 2122 2123 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let us check the CI here rather than waiting for the next daily run.
@@ -87,7 +87,7 @@ def env_with_temporary_pip_target(): | |||
|
|||
|
|||
@pytest.mark.slow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we temporarily comment out this slow
mark to include the test in this PR checks?
If the checks pass, let's put the mark back and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what you mean by check the CI here? I thought the PR checks were handling that, but I could be mistaken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If test is decorated with @pytest.mark.slow
it is not included in the CI checks executed for the PR and instead runs in scheduled daily workflows. Removing/commenting the slow mark will run the test in PR checks and we'll know if the fix worked sooner.
7525276
to
d292ed6
Compare
In failed changed files test:
Let's add the |
The checks passed with the slow mark removed: https://github.com/quantumlib/Cirq/actions/runs/7064136655/job/19231563262?pr=6366 I will restore the slow mark and push. |
0ce99be
to
4306fcc
Compare
I downloaded the artifacts, but don't see that file in the zip. |
Retriggered the checks and that problem went away. |
dev_tools/notebooks/notebook_test.py
Outdated
@@ -87,7 +87,7 @@ def env_with_temporary_pip_target(): | |||
|
|||
|
|||
@pytest.mark.slow | |||
@pytest.mark.skipif(sys.platform != "linux", reason="Linux-only test") | |||
@pytest.mark.skipif(sys.platform not in ["linux", "darwin"], reason="Linux/Mac-only test") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pytest.mark.skipif(sys.platform not in ["linux", "darwin"], reason="Linux/Mac-only test") | |
@only_on_posix |
please reuse the existing decorator from dev_tools.test_utils import only_on_posix
Otherwise LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after a small correction. Thank you!
Description
Address issue #6336 for macOS.
Testing
./check/pytest-changed-files -n auto --ignore=cirq-core/cirq/contrib --enable-slow-tests --verbose