-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI MacOS to fix notebook test error #6366
Merged
pavoljuhas
merged 10 commits into
quantumlib:main
from
smburdick:notebook-test-fix-macos
Dec 2, 2023
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e1e2f5c
Update CI MacOS to fix notebook test error
smburdick d292ed6
Remove slow tag from notebook test for PR testing.
smburdick 7cc2917
Merge branch 'main' into notebook-test-fix-macos
smburdick f118fd6
Update CI daily macos to address failing integ test
smburdick 2accbbe
move quimb import to notebook requirements
smburdick 4306fcc
Restore slow mark to notebook test.
smburdick 79adf36
Merge branch 'main' into notebook-test-fix-macos
smburdick 00a5722
retrigger notebook check
smburdick 388b5fa
Change to only on posix
smburdick 77ecc83
remove sys import
smburdick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -87,7 +87,7 @@ def env_with_temporary_pip_target(): | |||||
|
||||||
|
||||||
@pytest.mark.slow | ||||||
@pytest.mark.skipif(sys.platform != "linux", reason="Linux-only test") | ||||||
@pytest.mark.skipif(sys.platform not in ["linux", "darwin"], reason="Linux/Mac-only test") | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
please reuse the existing decorator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||||||
@pytest.mark.parametrize("notebook_path", filter_notebooks(list_all_notebooks(), SKIP_NOTEBOOKS)) | ||||||
def test_notebooks_against_cirq_head( | ||||||
notebook_path, require_packages_not_changed, env_with_temporary_pip_target | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we temporarily comment out this
slow
mark to include the test in this PR checks?If the checks pass, let's put the mark back and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what you mean by check the CI here? I thought the PR checks were handling that, but I could be mistaken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If test is decorated with
@pytest.mark.slow
it is not included in the CI checks executed for the PR and instead runs in scheduled daily workflows. Removing/commenting the slow mark will run the test in PR checks and we'll know if the fix worked sooner.