Remove non-deterministic hash from circuit diagram. #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanacles
commented
Nov 28, 2021
| @@ -88,11 +88,6 @@ def device(self) -> devices.Device: | |||
| def __hash__(self): | |||
| return hash((self.moments, self.device)) | |||
|
|
|||
| def diagram_name(self): | |||
There was a problem hiding this comment.
This is no longer used anywhere within the Cirq library. Do you think it is safe to remove?
There was a problem hiding this comment.
Seems fine to me - I only added it to handle the CircuitOperation tests.
thanacles
force-pushed
the
issue4240
branch
2 times, most recently
from
581f39e to
2a0b506
Compare
95-martin-orion
approved these changes
Nov 29, 2021
| @@ -88,11 +88,6 @@ def device(self) -> devices.Device: | |||
| def __hash__(self): | |||
| return hash((self.moments, self.device)) | |||
|
|
|||
| def diagram_name(self): | |||
There was a problem hiding this comment.
Seems fine to me - I only added it to handle the CircuitOperation tests.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Remove non-deterministic hash from circuit diagram. * Fix CI issues. Co-authored-by: Nate Thompson <thanacles@google.com>
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Remove non-deterministic hash from circuit diagram. * Fix CI issues. Co-authored-by: Nate Thompson <thanacles@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix bug #4240