Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check crd generator #876

Closed
wants to merge 24 commits into from
Closed

check crd generator #876

wants to merge 24 commits into from

Conversation

metacosm
Copy link
Member

@metacosm metacosm commented Apr 30, 2024 •
edited
Loading

No description provided.

metacosm and others added 17 commits April 25, 2024 20:12
@metacosm
chore: rebase on main, keep version intact to reduce distance with main
4e52afe 
[skip ci]
@metacosm
chore: update to proper next fabric8 version
5124750 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
chore: re-add snapshot repositories (NOT TO BE MERGED IN MAIN)
83521a9 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: move fabric8 override to BOM
a7ebe73 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: add Quarkus snapshots repository
5383313 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: move repository declarations to parent
e4f445d 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: add plugin repository for Quarkus snapshots
00596fe 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
feat: add dependency check step on failure
668d206 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: use Quarkus 3.7.1
4814276 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
chore: update to Fabric8 client to 6.11
5ce2184 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
chore(build): remove now unneeded repository configurations
1b95a44 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
chore: update to Fabric8 6.12-SNAPSHOT
5050cb0 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
feat: make it possible to build from a fabric8 client PR
273ee8f 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: make Quarkus and Fabric8 client PR numbers optional
f1254af 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: properly update FKC version
521d127 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: retrieve latest Quarkus version from registry by default
c0e303c 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
wip: meant to test fabric8io/kubernetes-client#5949
ca490c4 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm self-assigned this Apr 30, 2024
@metacosm metacosm requested a review from csviri April 30, 2024 19:47
@metacosm metacosm changed the base branch from main to next-fabric8-version April 30, 2024 19:47
metacosm added 2 commits April 30, 2024 22:10
@metacosm
fix: change fabric8 version as soon as PR is built if needed
bf728d9 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: should use existing version
334d7ec 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm force-pushed the check-crd-generator branch from 59937ea to 334d7ec Compare April 30, 2024 20:58
metacosm added 5 commits April 30, 2024 23:29
@metacosm
fix: change versions after profiles have been set
1a9c187 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: change f8 version before anything else for new deps to resolve
9d15aa6 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: properly use profiles
fcefa02 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: typo
c8bff6c 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
fix: change f8 version using sed instead of mvn
26f5914 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm force-pushed the check-crd-generator branch 2 times, most recently from a9f60d4 to 26f5914 Compare May 2, 2024 07:46
@metacosm metacosm force-pushed the next-fabric8-version branch 2 times, most recently from 12eda03 to c43c0db Compare May 16, 2024 08:14
@metacosm metacosm force-pushed the next-fabric8-version branch from c43c0db to 23e9ba1 Compare July 2, 2024 20:56
@baloo42 baloo42 mentioned this pull request Jul 3, 2024
Merged
11 tasks
@metacosm metacosm force-pushed the next-fabric8-version branch 2 times, most recently from df087ae to 5dbae78 Compare August 13, 2024 15:10
xstefank
xstefank approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe a little squash would be good.

@metacosm metacosm mentioned this pull request Aug 20, 2024
Merged
@metacosm
Copy link
Member Author

Replaced by #927

@metacosm metacosm closed this Aug 20, 2024
@metacosm metacosm deleted the check-crd-generator branch August 20, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xstefank xstefank xstefank approved these changes

@csviri csviri Awaiting requested review from csviri

Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metacosm @xstefank