feat: update to v2 version of Fabric8's CRD generator #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Laprun <claprun@redhat.com>
|
Replaces #876 |
Closed
xstefank
approved these changes
Aug 20, 2024
|
I will see if we can configure which version of the CRD generator to use. Can you use the 6.9.0 version that just got released, targeting Quarkus 3.17 or would this need to be backported to 6.8? |
|
@metacosm I can use 3.9. The problem is that without the backport 3.8 will generate invalid CRDs when default value is set for a anything but string field. So I guess the question is whether you want to also fix the 3.8.x line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun claprun@redhat.com