Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Keycloak version to 24 as Quarkus move to this version #1153

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Jun 2, 2024

Summary

Bumping the keycloak to 24.0 as upstream bump also bump it quarkusio/quarkus#40662

The big change is that keycloak now require email and first/last name to be set. The keycloak start without it but fail to token request.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97
Copy link
Member Author

jedla97 commented Jun 2, 2024

run tests

@rsvoboda rsvoboda added the triage/backport-1.4? Quarkus 3.8 stream label Jun 3, 2024
@rsvoboda
Copy link
Member

rsvoboda commented Jun 3, 2024

3.8 branch has this bump too

@jedla97
Copy link
Member Author

jedla97 commented Jun 3, 2024

run tests

@jedla97
Copy link
Member Author

jedla97 commented Jun 3, 2024

run tests

1 similar comment
@jedla97
Copy link
Member Author

jedla97 commented Jun 4, 2024

run tests

@jedla97
Copy link
Member Author

jedla97 commented Jun 4, 2024

Failure are not related.

@jedla97 jedla97 requested a review from michalvavrik June 4, 2024 13:13
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I already saw this last night

@michalvavrik michalvavrik merged commit ba744b6 into quarkus-qe:main Jun 4, 2024
9 of 10 checks passed
@jedla97 jedla97 removed the triage/backport-1.4? Quarkus 3.8 stream label Jun 12, 2024
@jedla97 jedla97 deleted the bump-keycloak-image branch June 12, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants