Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release version checker #1201

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Jul 11, 2024

Summary

PR contains:

  • Update release version checker to support both development and RHBQ release branches. Changes should be
    backported to 1.3.z and 1.4.z branches.
  • Adds check box to PR template with the note to follow releasing conventions described in the RELEASE.md

Example runs:
[main] success 1.5.0.Beta9 -> 1.5.0.Beta10
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9898569168/job/27345677181

[main] failure 1.5.0.Beta9 -> 1.5.0.Beta11
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9898590403/job/27345741503

[main] failure 1.5.0.Beta9 -> 1.5.1.Beta9
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9898619295/job/27345831135

First release from newely created branch 1.5.z

[1.5.z] failure - current-version: 1.6.0
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9921774174/job/27410101327

[1.5.z] success - current-version: 1.5.0
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9921803883/job/27410163653

After release 1.5.0

[main] failure: 1.5.0.Beta9 -> 1.5.0.Beta10
next LTS release branch is out, bump version to 1.6.0.Beta1
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9921906307/job/27410392342

[main] success 1.5.0.Beta9 -> 1.6.0.Beta1
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9927245152/job/27421961606

Set new pre-release to 1.6.0.Beta1

[main] failure 1.6.0.Beta1 -> 1.7.0.Beta1
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9928694191/job/27425317889

[1.5.z] failure - 1.5.0 -> 1.6.1
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9928857770/job/27425685357

[1.5.z] failure - 1.5.0 -> 1.5.2
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9928877759/job/27425727314

[1.5.z] failure - 1.5.0 -> 1.5.1.Beta1
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9928923886/job/27425829760

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk gtroitsk force-pushed the update-release-checker branch 3 times, most recently from 3386a5a to 309125a Compare July 14, 2024 17:02
@gtroitsk gtroitsk marked this pull request as ready for review July 14, 2024 17:17
@gtroitsk gtroitsk added triage/backport-1.3? Backport to 1.3 branch may be required triage/backport-1.4? Quarkus 3.8 stream labels Jul 14, 2024
Copy link
Contributor

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must admit this would be way easier to write it as Jbang script. I don't enjoy this bash scripting, but I'll review on Monday.

Copy link
Contributor

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice examples! Closing my eyes and thinking of England.

@michalvavrik michalvavrik removed the request for review from mjurc July 15, 2024 08:12
@michalvavrik
Copy link
Contributor

I removed @mjurc , please review when and if you have time for that. We can always make tweaks later.

@michalvavrik michalvavrik merged commit 52b6dd8 into quarkus-qe:main Jul 15, 2024
7 of 8 checks passed
@gtroitsk gtroitsk deleted the update-release-checker branch July 15, 2024 12:48
@mjurc
Copy link
Member

mjurc commented Jul 15, 2024

I think this is good, but please don't forget to backport this correctly into the affected branches :)

@gtroitsk gtroitsk removed triage/backport-1.4? Quarkus 3.8 stream triage/backport-1.3? Backport to 1.3 branch may be required labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants