Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.4.z] Update release version checker #1202

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[1.4.z] Update release version checker #1202

merged 1 commit into from
Jul 16, 2024

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Jul 16, 2024 •
edited
Loading

Summary

backports #1201

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Backport
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda
Copy link
Member

It's better to use -x option with cherry-pick command to have (cherry picked from commit …​) message amended to the commit message

Details: https://git-scm.com/docs/git-cherry-pick

Example: quarkusio/quarkus@f9d3818

@gtroitsk gtroitsk force-pushed the backport/1.4.update-release-checker branch from c9b177a to e3bad28 Compare July 16, 2024 09:39
@gtroitsk
Update release version checker
fbc0931 
(cherry picked from commit c003bcf)
@gtroitsk gtroitsk force-pushed the backport/1.4.update-release-checker branch from e3bad28 to fbc0931 Compare July 16, 2024 10:01
michalvavrik
michalvavrik approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik michalvavrik merged commit a31e17c into quarkus-qe:1.4.z Jul 16, 2024
6 of 7 checks passed
@gtroitsk gtroitsk deleted the backport/1.4.update-release-checker branch July 17, 2024 12:23
@gtroitsk gtroitsk mentioned this pull request Jul 19, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtroitsk @rsvoboda @michalvavrik