-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix QuarkusCliConfigEncryptIT for Windows OS #1238
Conversation
f5c2f04
to
1eac846
Compare
Following jobs contain at least one flaky test: 'Linux - JVM build - Latest Version' |
this fix is needed, @jcarranzan is testing it ATM, there are other places that could be escaped as well Line 62 in 1eac846
|
4b5ee3c
to
c448935
Compare
quarkus-test-cli/src/main/java/io/quarkus/test/bootstrap/config/QuarkusConfigCommandResult.java
Show resolved
Hide resolved
quarkus-test-cli/src/main/java/io/quarkus/test/bootstrap/config/QuarkusConfigCommandResult.java
Show resolved
Hide resolved
I did a partial fix and additional improvements needs to be done to be working on Windows OS because still there are other issues:
|
9344f40
to
2ab075a
Compare
2ab075a
to
b39e0ac
Compare
Remaining failure for the set config test I cannot fix after spending days on that. I think when it's consequence of default encoding. We cannot expect that it will work without adjusting of the defaults on executors. |
Summary
Currently there are some failures in our win jobs related to QuarkusCliConfigEncryptIT because special characters Strings in QuarkusCliConfigEncryptIT class on Windows OS
Please check the relevant options
run tests
phrase in comment)Checklist: