Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secretFormat on QuarkusCliConfigEncryptIT for Windows job #1918

Conversation

jcarranzan
Copy link
Contributor

Summary

Related to this test framewor changes--> quarkus-qe/quarkus-test-framework#1238
There are some failures in our win jenkins jobs related to QuarkusCliConfigEncryptIT because special characters and bold formatted Strings that affect the test execution on Windows OS.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan jcarranzan force-pushed the fix/fix-QuarkusCliConfigEncryptIT-on-Win branch from edcae30 to 43e302a Compare August 8, 2024 14:33
@rsvoboda
Copy link
Member

rsvoboda commented Aug 9, 2024

@jcarranzan pls fix format issues

@jcarranzan jcarranzan force-pushed the fix/fix-QuarkusCliConfigEncryptIT-on-Win branch from 2e35f05 to 115f51a Compare August 9, 2024 12:07
@jcarranzan jcarranzan force-pushed the fix/fix-QuarkusCliConfigEncryptIT-on-Win branch 2 times, most recently from 4d5073f to e9d68f7 Compare August 20, 2024 10:02
@michalvavrik
Copy link
Member

@jcarranzan time to rebase on current main and for review

@jcarranzan jcarranzan force-pushed the fix/fix-QuarkusCliConfigEncryptIT-on-Win branch from ef440c2 to 04f45d6 Compare August 26, 2024 12:00
@jcarranzan jcarranzan force-pushed the fix/fix-QuarkusCliConfigEncryptIT-on-Win branch from 04f45d6 to 5628ad7 Compare August 26, 2024 12:01
@michalvavrik michalvavrik marked this pull request as ready for review August 26, 2024 12:05
@michalvavrik michalvavrik merged commit 2531879 into quarkus-qe:main Aug 26, 2024
8 checks passed
@michalvavrik michalvavrik deleted the fix/fix-QuarkusCliConfigEncryptIT-on-Win branch August 26, 2024 14:05
@github-actions github-actions bot added the triage/flaky-test Signal that flaky tests were detected during CI run label Aug 26, 2024
Copy link

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

1 similar comment
Copy link

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/flaky-test Signal that flaky tests were detected during CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants