-
Notifications
You must be signed in to change notification settings - Fork 34
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add test coverage for the issue quarkusio/quarkus#43825
Ensure the missing servlet class in web.xml is ignored Test coverage for quarkusio/quarkus#44063 scenario
- Loading branch information
1 parent
94cbad7
commit f215332
Showing
3 changed files
with
74 additions
and
0 deletions.
There are no files selected for viewing
50 changes: 50 additions & 0 deletions
50
...let-undertow/src/test/java/io/quarkus/ts/http/undertow/UndertowMissingServletClassIT.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
package io.quarkus.ts.http.undertow; | ||
|
||
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; | ||
|
||
import java.io.IOException; | ||
import java.nio.file.Files; | ||
import java.nio.file.Path; | ||
import java.nio.file.StandardCopyOption; | ||
|
||
import org.junit.jupiter.api.Tag; | ||
import org.junit.jupiter.api.Test; | ||
|
||
import io.quarkus.test.bootstrap.RestService; | ||
import io.quarkus.test.bootstrap.Service; | ||
import io.quarkus.test.scenarios.QuarkusScenario; | ||
import io.quarkus.test.services.QuarkusApplication; | ||
|
||
@QuarkusScenario | ||
public class UndertowMissingServletClassIT { | ||
@QuarkusApplication(builder = WithMissingServlet.class) | ||
static RestService app = new RestService() | ||
.setAutoStart(false); | ||
|
||
@Tag("https://github.com/quarkusio/quarkus/issues/44063") | ||
@Test | ||
void verifyUndertowIgnoreServletClassMissing() { | ||
assertDoesNotThrow(() -> app.start(), | ||
"The app should start without any issue"); | ||
app.logs().assertDoesNotContain("Local name must not be null"); | ||
} | ||
|
||
public static void replaceForInvalidXML(Service service) { | ||
if (service instanceof RestService) { | ||
RestService restService = (RestService) service; | ||
Path invalidWebXml = Path.of("src/test/resources/META-INF/invalid-web.xml"); | ||
|
||
Path targetWebXml = restService.getServiceFolder().resolve("META-INF/web.xml"); | ||
try { | ||
Files.createDirectories(targetWebXml.getParent()); | ||
Files.copy(invalidWebXml, targetWebXml, StandardCopyOption.REPLACE_EXISTING); | ||
} catch (IOException e) { | ||
throw new RuntimeException("Failed to replace web.xml with invalid version", e); | ||
} | ||
} else { | ||
throw new IllegalArgumentException("Service is not an instance of RestService"); | ||
} | ||
|
||
} | ||
|
||
} |
14 changes: 14 additions & 0 deletions
14
http/servlet-undertow/src/test/java/io/quarkus/ts/http/undertow/WithMissingServlet.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package io.quarkus.ts.http.undertow; | ||
|
||
import static io.quarkus.ts.http.undertow.UndertowMissingServletClassIT.replaceForInvalidXML; | ||
|
||
import io.quarkus.test.services.quarkus.ProdQuarkusApplicationManagedResourceBuilder; | ||
|
||
public class WithMissingServlet extends ProdQuarkusApplicationManagedResourceBuilder { | ||
|
||
@Override | ||
protected void copyResourcesToAppFolder() { | ||
super.copyResourcesToAppFolder(); | ||
replaceForInvalidXML(getContext().getOwner()); | ||
} | ||
} |
10 changes: 10 additions & 0 deletions
10
http/servlet-undertow/src/test/resources/META-INF/invalid-web.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<web-app> | ||
<servlet> | ||
<servlet-name>InvalidServlet</servlet-name> | ||
</servlet> | ||
<servlet-mapping> | ||
<servlet-name>InvalidServlet</servlet-name> | ||
<url-pattern>/invalid</url-pattern> | ||
</servlet-mapping> | ||
</web-app> |