Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Quarkus CLI config tests on Quarkus version older than 3.13 due to breaking changes between 3.13 and 3.12 #1908

Merged

Conversation

michalvavrik
Copy link
Member

Summary

Disabling tests introduced in #1902 to fix Windows failures and make it possible to run Quarkus CLI module with older versions.

  • Improve Config CLI quarkusio/quarkus#41203 introduced breaking changes that I didn't mention
  • ATM our Windows runners use the latest released Quarkus 3.12
  • if anyone want to run Quarkus CLI module with older version to debug older versions, the test would fail

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's disable on all "relevant" versions for main.

@jedla97 jedla97 merged commit 07a3779 into quarkus-qe:main Jul 25, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/disable-cli-cmd-on-3-13 branch July 25, 2024 21:18
@rsvoboda
Copy link
Member

ATM our Windows runners use the latest released Quarkus 3.12

Talking about Jenkins? Because I realized our GH Actions are not running CLI tests - e.g. https://github.com/quarkus-qe/quarkus-test-suite/blob/main/.github/workflows/daily.yaml#L144 @michalvavrik

@michalvavrik
Copy link
Member Author

ATM our Windows runners use the latest released Quarkus 3.12

Talking about Jenkins? Because I realized our GH Actions are not running CLI tests - e.g. https://github.com/quarkus-qe/quarkus-test-suite/blob/main/.github/workflows/daily.yaml#L144 @michalvavrik

Yep, I meant AWS, our GH Windows runners are not running Quarkus CLI because there is no way to determine if this CLI test is starting a dev service or not. We would need to declare it on every test (which is acceptable).

@rsvoboda
Copy link
Member

ah, forgot about containers and dev services pains :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants