Improve Config CLI

[radcortez]

Fixes #41131

• Properly add help flags
• Moved required options to parameters
• Add a remove command

[gsmet]

Ah cool, I tried it the other day and it was a bit hard to use. I'll have a look soon.

[radcortez]

Should be easier now :)

[gsmet]

I'm having a look at it now.

[gsmet]

I played with it a bit and here is my feedback.
Not saying everything should be fixed before we merged this PR but I'd like to have your feedback on my comments.

1. I think quarkus config should display the help rather than defaulting to set. For me this is too important to push a random default.
2. I think the feedback should be consistent with the feedback we have when adding an extension for instance.

We have:

In general, we should try to be consistent on the feedback side.

3. When typing quarkus config enc, I end up with an error instead of the help being displaying (this is the case in main but also in this branch). I created Quarkus CLI - Some expected errors lead to a stacktrace and they shouldn't #41513 because even if you can tweak it here, I think it's something that is not ideal in our Picocli extension.

4. I'm not sure of why I have to pass the secret with --secret in quarkus config enc --secret=secret, for the rest you pass the parameters as is (or at least that's what I did and it worked).
   Also I have no idea what to do with the output:

Encrypted Secret: DBLLBaf7o_i3u8lmJBb0rKJT13xvBXoQYjVFWFCJACl_tGU
Encryption Key: S6i5aNG6ySALS6021eMKbg

We probably need to explain what to do with it?

[radcortez]

1. I think quarkus config should display the help rather than defaulting to set. For me this is too important to push a random default.

OK

2. I think the feedback should be consistent with the feedback we have when adding an extension for instance.

In general, we should try to be consistent on the feedback side.

OK

3. When typing quarkus config enc, I end up with an error instead of the help being displaying (this is the case in main but also in this branch). I created Picocli - Some expected errors lead to a stacktrace and they shouldn't #41513 because even if you can tweak it here, I think it's something that is not ideal in our Picocli extension.

Yes, this is an issue with our extension rather than the CLI commands. When I looked into other examples, we also got the same error (for instance, quarkus extension add without any parameter also ends up with a stacktrace). I then forgot to open an issue about it. Thanks for opening one. It seems this happens only with subcommands.

4. I'm not sure of why I have to pass the secret with --secret in quarkus config enc --secret=secret, for the rest you pass the parameters as is (or at least that's what I did and it worked).

Strange. It shouldn't be that way anymore. The previous version did have a --secret option but I've changed that to be a parameter.

Also I have no idea what to do with the output:

Encrypted Secret: DBLLBaf7o_i3u8lmJBb0rKJT13xvBXoQYjVFWFCJACl_tGU
Encryption Key: S6i5aNG6ySALS6021eMKbg

We probably need to explain what to do with it?

OK

[radcortez]

This is how it is looking now:

[gsmet]

Love it!

[michalvavrik]

Some changes here (Moved required options to parameters: SECRET, NAME, VALUE) are not backwards compatible, but I can't find it documented in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.13 and this PR does not have a breaking-change label. Can you improve this, please?

[radcortez]

Hey @michalvavrik sorry for the inconvenience.

We made the changes to fix some of the raised issues, plus make it consistent with other Quarkus CLI commands. I'll add that information now.

[michalvavrik]

Hey @michalvavrik sorry for the inconvenience.

We made the changes to fix some of the raised issues, plus make it consistent with other Quarkus CLI commands. I'll add that information now.

np, but good to have it documented, thanks

[radcortez]

https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.13#quarkus-cli