Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom User-Agent header ignored #36329

Closed
luca-vercelli opened this issue Oct 6, 2023 · 2 comments · Fixed by #36377
Closed

Custom User-Agent header ignored #36329

luca-vercelli opened this issue Oct 6, 2023 · 2 comments · Fixed by #36377
Labels
area/rest-client env/windows Impacts Windows machines kind/bug Something isn't working
Milestone
3.2.8.Final

Comments

@luca-vercelli
Copy link

luca-vercelli commented Oct 6, 2023 •
edited
Loading

Describe the bug

We have a reactive rest client where we set a custom User-Agent header via the @ClientHeaderParam annotation.
However this is ignored and replaced with "Resteasy Reactive Client".

This does not happen with legacy resteasy client.

See also issue #23966. In that issue a workaround is described (using a ClientHeadersFactory).

Expected behavior

The HTTP call should include the header User-Agent: my-custom-header

Actual behavior

The HTTP call includes the header User-Agent: Resteasy Reactive Client

How to Reproduce?

You need any rest client

@Path("/somepath")
@ClientHeaderParam(name = "User-Agent", value = "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.95 Safari/537.11") 
@RegisterRestClient
public interface MyApi {

  @GET
  Response somepath();

}

and call it via

@Inject
@RestClient
MyApi  api;

....
api.somepath()

Output of uname -a or ver

Microsoft Windows [Versione 10.0.19045.3208]

Output of java -version

java version "11.0.18" 2023-01-17 LTS

GraalVM version (if different from Java)

No response

Quarkus version or git rev

3.4.2

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.9.0

Additional information

No response
@luca-vercelli luca-vercelli added the kind/bug Something isn't working label Oct 6, 2023
@quarkus-bot quarkus-bot bot added env/windows Impacts Windows machines triage/needs-triage labels Oct 6, 2023
geoand added a commit to geoand/quarkus that referenced this issue Oct 10, 2023
@geoand
Allow @ClientHeaderParam to override User-Agent
134f462 
Fixes: quarkusio#36329
@geoand geoand mentioned this issue Oct 10, 2023
Merged
@geoand
Copy link
Contributor

geoand commented Oct 10, 2023

Thanks, #36377 fixes the issue

@luca-vercelli
Copy link
Author

Thank you

geoand added a commit that referenced this issue Oct 10, 2023
@geoand
Merge pull request #36377 from geoand/#36329
9d364d2 
Allow @ClientHeaderParam to override User-Agent
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Oct 10, 2023
@gsmet gsmet modified the milestones: 3.5.0.CR1, 3.4.3 Oct 11, 2023
gsmet pushed a commit to gsmet/quarkus that referenced this issue Oct 11, 2023
@geoand @gsmet
Allow @ClientHeaderParam to override User-Agent
24f25ab 
Fixes: quarkusio#36329
(cherry picked from commit 134f462)
@aloubyansky aloubyansky modified the milestones: 3.4.3, 3.2.8.Final Nov 2, 2023
aloubyansky pushed a commit to aloubyansky/quarkus that referenced this issue Nov 2, 2023
@geoand @aloubyansky
Allow @ClientHeaderParam to override User-Agent
1156fe7 
Fixes: quarkusio#36329
(cherry picked from commit 134f462)
benkard pushed a commit to benkard/mulkcms2 that referenced this issue Nov 12, 2023
Update all non-major dependencies (mulk/mulkcms2!41)
929c0d5 
This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [flow-bin](https://github.com/flowtype/flow-bin) ([changelog](https://github.com/facebook/flow/blob/master/Changelog.md)) | devDependencies | minor | [`^0.217.0` -> `^0.219.0`](https://renovatebot.com/diffs/npm/flow-bin/0.217.2/0.219.0) |
| [io.hypersistence:hypersistence-utils-hibernate-62](https://github.com/vladmihalcea/hypersistence-utils) | compile | minor | `3.5.3` -> `3.6.0` |
| [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | patch | `3.4.2` -> `3.4.3` |
| [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | patch | `3.4.2` -> `3.4.3` |

---

### Release Notes

<details>
<summary>flowtype/flow-bin</summary>

### [`v0.219.0`](flow/flow-bin@1268ec5...c184c5d)

[Compare Source](flow/flow-bin@1268ec5...c184c5d)

### [`v0.218.1`](flow/flow-bin@12afce4...1268ec5)

[Compare Source](flow/flow-bin@12afce4...1268ec5)

### [`v0.218.0`](flow/flow-bin@dc93913...12afce4)

[Compare Source](flow/flow-bin@dc93913...12afce4)

</details>

<details>
<summary>vladmihalcea/hypersistence-utils</summary>

### [`v3.6.0`](https://github.com/vladmihalcea/hypersistence-utils/blob/HEAD/changelog.txt#Version-360---October-12-2023)

\================================================================================

Implement QueryStackTraceLogger using StackWalker [#&#8203;659](vladmihalcea/hypersistence-utils#659)

Add JFR based query logger [#&#8203;658](vladmihalcea/hypersistence-utils#658)

Adds support for using MonetaryAmount in [@&#8203;ElementCollection](https://github.com/ElementCollection) [#&#8203;652](vladmihalcea/hypersistence-utils#652)

</details>

<details>
<summary>quarkusio/quarkus</summary>

### [`v3.4.3`](https://github.com/quarkusio/quarkus/releases/tag/3.4.3)

[Compare Source](quarkusio/quarkus@3.4.2...3.4.3)

##### Complete changelog

-   [#&#8203;36408](quarkusio/quarkus#36408) - Ensure that SSE builder works in native
-   [#&#8203;36404](quarkusio/quarkus#36404) - Do not exclude properties from recording that are available in sources that should always be included
-   [#&#8203;36403](quarkusio/quarkus#36403) - IBM Db2 - Register resource bundle classes for reflection
-   [#&#8203;36402](quarkusio/quarkus#36402) - Native Picocli build breaks SSE client
-   [#&#8203;36399](quarkusio/quarkus#36399) - quarkus-jdbc-db2: resource bundle missing
-   [#&#8203;36377](quarkusio/quarkus#36377) - Allow `@ClientHeaderParam` to override User-Agent
-   [#&#8203;36371](quarkusio/quarkus#36371) - Fix issue in Java migration in dev-mode
-   [#&#8203;36351](quarkusio/quarkus#36351) - Properly handle invalid response body errors in Reactive REST Client
-   [#&#8203;36329](quarkusio/quarkus#36329) - Custom User-Agent header ignored
-   [#&#8203;36326](quarkusio/quarkus#36326) - Cannot load fixed or default YAML configuration when running native build
-   [#&#8203;36302](quarkusio/quarkus#36302) - Fix headers and preambles in all guides and reintroduce some keywords
-   [#&#8203;36299](quarkusio/quarkus#36299) - quarkus-flyway: Java-Migration does not get picked up on live reload
-   [#&#8203;36290](quarkusio/quarkus#36290) - Fixed URL for configuring JSON support
-   [#&#8203;36257](quarkusio/quarkus#36257) - Rest client call hangs when receiving an invalid chunked response and does not release resources (e.g. Bulkhead semaphore)
-   [#&#8203;36147](quarkusio/quarkus#36147) - Bump org.eclipse.parsson:parsson from 1.1.2 to 1.1.4
-   [#&#8203;36096](quarkusio/quarkus#36096) - Build cache - Use notCacheableBecause instead of storeEnabled
-   [#&#8203;35929](quarkusio/quarkus#35929) - Do not store build cache for core extensions having config
-   [#&#8203;35927](quarkusio/quarkus#35927) - Build cache - Core extensions containing config shouldn't be cached
-   [#&#8203;35769](quarkusio/quarkus#35769) - Default response content type using GraphQL spec

</details>

<details>
<summary>quarkusio/quarkus-platform</summary>

### [`v3.4.3`](quarkusio/quarkus-platform@3.4.2...3.4.3)

[Compare Source](quarkusio/quarkus-platform@3.4.2...3.4.3)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Feb 8, 2024
@geoand @holly-cummins
Allow @ClientHeaderParam to override User-Agent
f673f19 
Fixes: quarkusio#36329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/rest-client env/windows Impacts Windows machines kind/bug Something isn't working
Projects
None yet
Milestone
3.2.8.Final
Development

Successfully merging a pull request may close this issue.

Allow @ClientHeaderParam to override User-Agent geoand/quarkus
4 participants
@aloubyansky @gsmet @geoand @luca-vercelli