Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatic module name of the change agent #30807

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Feb 2, 2023

class is not allowed in an automatic module name. klass will work.

Fixes: #29719
Fixes: #28919

@quarkus-bot

This comment was marked as resolved.

@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven labels Feb 2, 2023
@triceo triceo changed the title Fix automatic module name of the change agent (fixes #29719) Fix #29719: Automatic module name of the change agent Feb 2, 2023
@triceo triceo changed the title Fix #29719: Automatic module name of the change agent Fix automatic module name of the change agent Feb 2, 2023
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@triceo
Copy link
Contributor Author

triceo commented Feb 2, 2023

@geoand Any chance we could backport to 2.16?
(Asking as this is blocking me from bumping Javadoc plugin version in OptaPlanner, and I want to do that while still being compatible with 2.x.)

@geoand
Copy link
Contributor

geoand commented Feb 2, 2023

I kinda doubt we'll do that, but up to @gsmet

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 2, 2023

Failing Jobs - Building fe95e5f

Status Name Step Failures Logs Raw logs
Native Tests - Data6 Build ⚠️ Check → Logs Raw logs

@geoand geoand merged commit 4f9396d into quarkusio:main Feb 3, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Feb 3, 2023
geoand added a commit to geoand/quarkus that referenced this pull request Feb 3, 2023
Doing this in response to a timeout seen in quarkusio#30807
@triceo triceo deleted the agent branch February 3, 2023 08:58
@gsmet
Copy link
Member

gsmet commented Feb 4, 2023

If you create a pull request with a relocation in the relocations/ directory, I could be convinced to backport it.

@geoand
Copy link
Contributor

geoand commented Feb 4, 2023

Didn't think about that, it's a good idea

@gsmet
Copy link
Member

gsmet commented Feb 4, 2023

Hmmm. In fact I would prefer we revert this change entirely. We should be able to just override the automatic module name instead of changing the artifact name.
See https://github.com/hibernate/hibernate-validator/blob/main/engine/pom.xml#L223-L244 for an example.

@triceo is there a reason why you haven't chosen this approach?

@triceo
Copy link
Contributor Author

triceo commented Feb 4, 2023

@gsmet The reason was that I do not understand the Quarkus build well enough to be able to say where is the right place to set the automatic module name.

  • I looked through the codebase and it is never overriden anywhere, so I couldn't take a hint.
  • I could simply configure the JAR plugin to do it, but I don't know if it could interfere with some sort of productization settings somewhere.

If configuring the JAR plugin is the recommended way to go, I can do it.

galderz pushed a commit to galderz/quarkus that referenced this pull request Feb 13, 2023
Doing this in response to a timeout seen in quarkusio#30807
galderz pushed a commit to galderz/quarkus that referenced this pull request Feb 15, 2023
Doing this in response to a timeout seen in quarkusio#30807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven kind/bugfix
Projects
None yet
3 participants