-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix automatic module name of the change agent #30807
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@geoand Any chance we could backport to 2.16? |
I kinda doubt we'll do that, but up to @gsmet |
Doing this in response to a timeout seen in quarkusio#30807
If you create a pull request with a relocation in the |
Didn't think about that, it's a good idea |
Hmmm. In fact I would prefer we revert this change entirely. We should be able to just override the automatic module name instead of changing the artifact name. @triceo is there a reason why you haven't chosen this approach? |
@gsmet The reason was that I do not understand the Quarkus build well enough to be able to say where is the right place to set the automatic module name.
If configuring the JAR plugin is the recommended way to go, I can do it. |
Doing this in response to a timeout seen in quarkusio#30807
Doing this in response to a timeout seen in quarkusio#30807
class
is not allowed in an automatic module name.klass
will work.Fixes: #29719
Fixes: #28919