Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package statements that do not correspond to the project directory structure #1116

Closed
e210 opened this issue Apr 8, 2024 · 2 comments
Closed

Package statements that do not correspond to the project directory structure #1116

e210 opened this issue Apr 8, 2024 · 2 comments
Assignees
@jhouserizer
Labels
is:bug Bugs to fix needs:review Needs review / investigation

Comments

@e210
Copy link
Contributor

e210 commented Apr 8, 2024

The classes in the directory quartz/src/main/java/org/quartz/ee/jboss are referencing a package that does not match the actual structure.
While not strictly mandated by the Java language, it's considered good practice.
@jhouserizer jhouserizer added the needs:review Needs review / investigation label Oct 14, 2024
@jhouserizer
Copy link
Contributor

That's just weird and yucky. Many years of precedence of it now for those files... will ponder about correcting it.

@jhouserizer jhouserizer self-assigned this Oct 16, 2024
@jhouserizer jhouserizer added the is:bug Bugs to fix label Oct 16, 2024
@bcode2
Copy link
Contributor

bcode2 commented Oct 16, 2024

Yeaa, quite strange that the bug is so old. I have just push a PR regarding this issue

@jhouserizer jhouserizer mentioned this issue Oct 16, 2024
Merged
4 tasks
jhouserizer added a commit that referenced this issue Oct 16, 2024
@jhouserizer
Merge pull request #1208 from bcode2/refactor-quartz-2.4.x
d5230eb 
fix #1116: Move classes to the correct folder following java recommended package naming conventions
bcode2 added a commit to bcode2/quartz that referenced this issue Oct 17, 2024
@bcode2
fix: quartz-scheduler#1116-Move classes to the correct folder followi…
27936ad 
…ng java recommended package naming conventions

Signed-off-by: Carlos Garcia <bcode@protonmail.com>
@bcode2 bcode2 mentioned this issue Oct 17, 2024
Merged
4 tasks
jhouserizer added a commit that referenced this issue Oct 17, 2024
@jhouserizer
Merge pull request #1215 from bcode2/fix-#1116-Move_branch-2.5
67da376 
fix: #1116-Move classes to the correct folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhouserizer jhouserizer

Labels
is:bug Bugs to fix needs:review Needs review / investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@e210 @jhouserizer @bcode2