Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1116: Move classes to the correct folder following java recommended package naming conventions #1208

Merged

Conversation

bcode2
Copy link
Contributor

@bcode2 bcode2 commented Oct 16, 2024

…ckage naming convention

This PR...

Fixes issue #1116
fix: Move classes to the correct folder following java recommended package naming conventions

Changes


Checklist

  • tested locally
  • updated the docs
  • added appropriate test
  • signed-off on the DCO referenced in the CONTRIBUTING link below via git commit -s on my commits, and submit this code under terms of the Apache 2.0 license and assign copyright to the Quartz project owners
    (If you're not using command-line, you can use a browser extension )

In submitting this contribution, I agree to the terms of contributing as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md

…ckage naming convention

Signed-off-by: Carlos Garcia <bcode@protonmail.com>
@bcode2
Copy link
Contributor Author

bcode2 commented Oct 16, 2024

The same will have to be done in 2.5 branch. I guess it is better to keep the package name, this way any class that use them are not updated.

@jhouserizer jhouserizer changed the title fix: Move classes to the correct folder following java recommended package naming conventions fix #1116: Move classes to the correct folder following java recommended package naming conventions Oct 16, 2024
@jhouserizer
Copy link
Contributor

Thanks. Will you be doing main (2.5.x) also?

@jhouserizer jhouserizer merged commit d5230eb into quartz-scheduler:quartz-2.4.x Oct 16, 2024
4 checks passed
@bcode2
Copy link
Contributor Author

bcode2 commented Oct 16, 2024

yes sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants