Simpler and more precise ID flow control update check in Chunks #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
May 21, 2024
Bi-directional streams might not be freed immediately on reading to end or receiving a reset, and `StreamsState::stream_freed` already performs the exact accounting required for this case when we call it on entering Finished or Reset state.
Ralith
force-pushed
the
recv-cleanup-2
branch
2 times, most recently
from
a5072b6
to
856441f
Compare
djc
approved these changes
May 22, 2024
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this looked like a redundant approximation while working on #1873. Careful review desired. The original logic here seems to date back to 2021 or earlier, but e.g. a3b35f9 looks like a somewhat shorter-sighted hack around this same quirk. See commit description for additional rationale.